Remove a flaky and unnecessary check #114251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this.
Member
|
@llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) ChangesThe order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. Full diff: https://github.com/llvm/llvm-project/pull/114251.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py
index 0919eb3c5dd812..93d5392830b508 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/TestInitializerList.py
@@ -40,5 +40,3 @@ def test(self):
"frame variable ils",
substrs=['[4] = "surprise it is a long string!! yay!!"'],
)
-
- self.expect("image list", substrs=self.getLibcPlusPlusLibs())
|
Michael137
approved these changes
Oct 30, 2024
JDevlieghere
approved these changes
Oct 30, 2024
adrian-prantl
added a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Oct 30, 2024
The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this. (cherry picked from commit eac2c18)
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order in which the libraries appear is not always stable and even if it were, this test is not the right place to check for this.