Skip to content

[NFC] [clang] Use std::string instead of StringRef to reduce stack usage #114285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[NFC] [clang] Use std::string instead of StringRef to reduce stack usage #114285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e075173
[NFC] [clang] Use std::string instead of StringRef to reduce stack usage
chinmaydd Oct 30, 2024
a1ab03f
Fix syntax and formatting issues
chinmaydd Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clang/lib/Basic/Attributes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,10 @@ unsigned AttributeCommonInfo::calculateAttributeSpellingListIndex() const {
// Both variables will be used in tablegen generated
// attribute spell list index matching code.
auto Syntax = static_cast<AttributeCommonInfo::Syntax>(getSyntax());
StringRef Scope = normalizeAttrScopeName(getScopeName(), Syntax);
StringRef Name = normalizeAttrName(getAttrName(), Scope, Syntax);
// We use std::string instead of StringRef to prevent local stack
// allocation of literal strings for comparison.
const std::string Scope = normalizeAttrScopeName(getScopeName(), Syntax);
const std::string Name = normalizeAttrName(getAttrName(), Scope, Syntax);

#include "clang/Sema/AttrSpellingListIndex.inc"
}
Loading