Skip to content

[SelectionDAG] Remove unneeded assert from SelectionDAG::getSignedConstant. NFC #114336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topperc merged 3 commits into from
Nov 4, 2024
Merged

[SelectionDAG] Remove unneeded assert from SelectionDAG::getSignedConstant. NFC #114336

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f9af2c
[SelectionDAG] Remove unneeded assert from SelectionDAG::getSignedCon…
topperc Oct 31, 2024
a4a1ddb
Merge remote-tracking branch 'origin/main' into pr/signedconstant
topperc Nov 4, 2024
df90116
fixup! remove implicitTrunc=false
topperc Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,10 +1773,9 @@ SDValue SelectionDAG::getConstant(const ConstantInt &Val, const SDLoc &DL,
SDValue SelectionDAG::getSignedConstant(int64_t Val, const SDLoc &DL, EVT VT,
bool isT, bool isO) {
unsigned Size = VT.getScalarSizeInBits();
assert(
isIntN(Size, Val) &&
"getSignedConstant with a int64_t value that doesn't fit in the type!");
return getConstant(APInt(Size, Val, true), DL, VT, isT, isO);
return getConstant(
APInt(Size, Val, /*isSigned=*/true, /*implicitTrunc=*/false), DL, VT, isT,
isO);
}

SDValue SelectionDAG::getAllOnesConstant(const SDLoc &DL, EVT VT, bool IsTarget,
Expand Down
Loading