-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[llvm-(min-)tblgen] Avoid redundant source compilation #114494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
94dd647
[llvm-(min-)tblgen] Avoid redundant source compilation
Meinersbur a35bd89
No additional object library necessary
Meinersbur 3234b52
Revert "No additional object library necessary"
Meinersbur 4d31243
Move common files to TabeGenBasic
Meinersbur d79ea2f
Merge branch 'main' into llvm_tblgen_both
Meinersbur 69092f8
Merge branch 'main' into llvm_tblgen_both
Meinersbur db0cafc
Apply @chapuni's suggestion
Meinersbur 640a872
Keep TableGen.cpp filename
Meinersbur 52c41a6
Merge branch 'main' into llvm_tblgen_both
Meinersbur a1849e6
Fix double use of llvm-min-tblgen.cpp
Meinersbur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest
TableGen.cppmay be individual. IIRC, some cmake generators don't likeadd_executablew/o any source files.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake has a problem to identify which linker to use (C or C++) when there is no .c/.cpp file in the list. A strategy used elsewhere also in LLVM adds an empty
dummy.cppinto the list.Keeping
TableGen.cpp(or using the samedummy.cpp) in both executables would defeat the entire purpose of this patch: The same timestamp issue still occurs with even just a single file which causes all .td files to be processed again in a no-change build (see summary).I instead applied the usual source structure of an executable: One file per executable which named after the executable name containing the (in this case trivial)
mainfunction, which just calls thetblgen_maininTableGen.cpp. This should also clear up any confusion (including mine) of where each executable's main function is.