Skip to content

[OpenMP] Using SimpleVLA to handle vla usage in ompt-general.cpp. #114583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[OpenMP] Using SimpleVLA to handle vla usage in ompt-general.cpp. #114583

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f1cd55
[OpenMP] Ignore the error introduced by -Wvla-cxx-extension on ompt-g…
DanielCChen Nov 1, 2024
608bfd2
[OpenMP] to address the review comments to use template SimpleVLA.
DanielCChen Nov 1, 2024
8ff6304
Move LLVM headers before system headers.
DanielCChen Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openmp/runtime/src/ompt-general.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#if KMP_OS_UNIX
#include <dlfcn.h>
#endif
#include "kmp_utils.h"
Copy link
Contributor

@shiltian shiltian Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it in the right order?

Copy link
Contributor Author

@DanielCChen DanielCChen Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it in the right order?

Could you please be more specific? @shiltian

Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielCChen, I think https://llvm.org/docs/CodingStandards.html#include-style says that this header should be moved up. Indeed, it wouldn't fit under the "system include files" comment.

I don't know what to say about the include of ompt-specific.cpp (yes, .cpp!) below.

Copy link
Contributor

@shiltian shiltian Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is what I meant.

I don't know what to say about the include of ompt-specific.cpp (yes, .cpp!) below.

Me neither. ;-) That is before libomp was contributed to LLVM.

Copy link
Contributor Author

@DanielCChen DanielCChen Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will move it before the system #include then.


/*****************************************************************************
* ompt include files
Expand Down Expand Up @@ -708,7 +709,7 @@ OMPT_API_ROUTINE int ompt_get_place_proc_ids(int place_num, int ids_size,
return 0;
#else
int i, count;
int tmp_ids[ids_size];
SimpleVLA<int> tmp_ids(ids_size);
for (int j = 0; j < ids_size; j++)
tmp_ids[j] = 0;
if (!KMP_AFFINITY_CAPABLE())
Expand Down
Loading