[mlir][affine] Add unit tests for isProjectedPermutation
#114775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir Author: Andrzej Warzyński (banach-space) ChangesThe only way to test Full diff: https://github.com/llvm/llvm-project/pull/114775.diff 1 Files Affected:
diff --git a/mlir/unittests/IR/AffineMapTest.cpp b/mlir/unittests/IR/AffineMapTest.cpp
index 081afadd632f1b..2c96c69a69d203 100644
--- a/mlir/unittests/IR/AffineMapTest.cpp
+++ b/mlir/unittests/IR/AffineMapTest.cpp
@@ -21,3 +21,44 @@ TEST(AffineMapTest, inferMapFromAffineExprs) {
map.replace(replacements);
EXPECT_EQ(map, map);
}
+
+TEST(AffineMapTest, isProjectedPermutation) {
+ MLIRContext ctx;
+ OpBuilder b(&ctx);
+
+ // 1. Empty map - a projected permutation.
+ AffineMap map1 = b.getEmptyAffineMap();
+ EXPECT_TRUE(map1.isProjectedPermutation());
+
+ // 2. Contains a symbol - not a projected permutation.
+ AffineMap map2 = AffineMap::get(0, 1, &ctx);
+ EXPECT_FALSE(map2.isProjectedPermutation());
+
+ // 3. The result map is {0} - since zero results are _allowed_, this _is_ a
+ // projected permutation.
+ auto zero = b.getAffineConstantExpr(0);
+ AffineMap map3 = AffineMap::get(1, 0, {zero}, &ctx);
+ EXPECT_TRUE(map3.isProjectedPermutation(/*allowZeroInResults=*/true));
+
+ // 4. The result map is {0} - since zero results are _not allowed_, this _is not_
+ // a projected permutation.
+ AffineMap map4 = AffineMap::get(1, 0, {zero}, &ctx);
+ EXPECT_FALSE(map4.isProjectedPermutation(/*allowZeroInResults=*/false));
+
+ // 5. The number of results > inputs, not a projected permutation.
+ AffineMap map5 = AffineMap::get(1, 0, {zero, zero}, &ctx);
+ EXPECT_FALSE(map5.isProjectedPermutation(/*allowZeroInResults=*/true));
+
+ // 6. A constant result that's not a {0} - not a projected permutation.
+ auto one = b.getAffineConstantExpr(1);
+ AffineMap map6 = AffineMap::get(1, 0, {one}, &ctx);
+ EXPECT_FALSE(map6.isProjectedPermutation(/*allowZeroInResults=*/true));
+
+ // 7. Not a dim expression - not a projected permutation.
+ auto d0 = b.getAffineDimExpr(0);
+ auto d1 = b.getAffineDimExpr(1);
+
+ auto sum = d0 + d1;
+ AffineMap map7 = AffineMap::get(2, 0, {sum}, &ctx);
+ EXPECT_FALSE(map7.isProjectedPermutation());
+}
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
The only way to test `isProjectedPermutation` is through unit tests. The concept of "projected permutations" is tricky to document and these tests are a good source documentation of the expected/intended behavoiur. Hence these additional unit tests.
banach-space
force-pushed
the
andrzej/add_unit_tests_for_map
branch
from
dc8ada1 to
9f03639
Compare
javedabsar1
requested changes
Nov 4, 2024
Contributor
javedabsar1
left a comment
javedabsar1
left a comment
There was a problem hiding this comment.
Thanks for this. ProjectedPermutation is used in many places and these are very instructive tests.
mlir/unittests/IR/AffineMapTest.cpp
Outdated
| MLIRContext ctx; | ||
| OpBuilder b(&ctx); | ||
|
|
||
| // 1. Empty map - a projected permutation. |
Contributor
There was a problem hiding this comment.
its a 'projected permutation' test and TRUE, FALSE tells the expected so no need to repeat 'a projected permutation'
Contributor
Author
There was a problem hiding this comment.
Good suggestion, thanks!
| // 7. Not a dim expression - not a projected permutation. | ||
| auto d0 = b.getAffineDimExpr(0); | ||
| auto d1 = b.getAffineDimExpr(1); | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe add some tougher tests
(d0,d1, d2, d3,d4,d5) ->(d5,d3,d0,d1,d2,d4)
(d0,d1, d2, d3,d4,d5) ->(d5,d3,d0+d1,d2,d4)
(d0,d1, d2, d3,d4,d5) ->(d5,d3,d2,d4)
Contributor
Author
There was a problem hiding this comment.
Yup, thanks, about to add these.
Fix comments, add more cases
banach-space
force-pushed
the
andrzej/add_unit_tests_for_map
branch
from
f06eb81 to
ef83b59
Compare
javedabsar1
approved these changes
Nov 5, 2024
Contributor
javedabsar1
left a comment
javedabsar1
left a comment
There was a problem hiding this comment.
Looks great now. Thanks.
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
The only way to test `isProjectedPermutation` is through unit tests. The concept of "projected permutations" is tricky to document and these tests are a good source documentation of the expected/intended behavoiur. Hence these additional unit tests.
banach-space
added a commit
to banach-space/llvm-project
that referenced
this pull request
Nov 20, 2024
The only way to test `getInversePermutation` is through unit tests. The concept of "inverse permutations" is tricky to document and these tests are a good source documentation of the expected/intended behavoiur. Hence these additional unit tests. This is a follon-on llvm#114775 for in which I added tests for `isProjectedPermutation`.
banach-space
added a commit
that referenced
this pull request
Nov 22, 2024
The only way to test `getInversePermutation` is through unit tests. The concept of "inverse permutations" is tricky to document and these tests are a good source documentation of the expected/intended behavoiur. Hence these additional unit tests. This is a follow-on of #114775 in which I added tests for `isProjectedPermutation`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to test
isProjectedPermutationis through unit tests. Theconcept of "projected permutations" is tricky to document and these
tests are a good source documentation of the expected/intended
behavoiur. Hence these additional unit tests.