-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[C2y] Add test coverage for WG14 N3370 #115054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| // RUN: %clang_cc1 -verify=expected,c-expected -std=c2y -Wall -pedantic %s | ||
| // RUN: %clang_cc1 -verify=expected,c-expected,ped -std=c23 -Wall -pedantic %s | ||
| // RUN: %clang_cc1 -verify=expected,cxx-expected,gnu -Wall -pedantic -x c++ %s | ||
| // RUN: %clang_cc1 -verify=expected,c-expected,pre -std=c2y -Wpre-c2y-compat -Wall -pedantic %s | ||
|
|
||
| /* WG14 N3370: Yes | ||
| * Case range expressions v3.1 | ||
| * | ||
| * This introduces the ability to specify closed ranges in case statements in a | ||
| * switch statement. This was already a well-supported Clang extension before | ||
| * it was standardized. | ||
| */ | ||
|
|
||
| void correct(int i) { | ||
| constexpr int j = 100, k = 200; | ||
| switch (i) { | ||
| case 12 ... 14: break; /* gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| // Implementations are encouraged to diagnose empty ranges. | ||
| case 15 ... 11: break; /* expected-warning {{empty case range specified}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| // This is not an empty range, it's a range of a single value. | ||
| case 10 ... 10: break; /* gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| case j ... k: break; /* gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| } | ||
| } | ||
|
|
||
| void incorrect(int i) { // cxx-expected-note 2 {{declared here}} | ||
| switch (i) { | ||
| // The values have to be integer constant expressions. Note that when the | ||
| // initial value in the range is an error, we don't issue the warnings about | ||
| // extensions or incompatibility. | ||
| case i ... 10: break; /* c-expected-error {{expression is not an integer constant expression}} | ||
| cxx-expected-error {{case value is not a constant expression}} | ||
| cxx-expected-note {{function parameter 'i' with unknown value cannot be used in a constant expression}} | ||
| */ | ||
| case 10 ... i: break; /* c-expected-error {{expression is not an integer constant expression}} | ||
| cxx-expected-error {{case value is not a constant expression}} | ||
| cxx-expected-note {{function parameter 'i' with unknown value cannot be used in a constant expression}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| case 1.3f ... 10: break; /* c-expected-error {{integer constant expression must have integer type, not 'float'}} | ||
| cxx-expected-error {{conversion from 'float' to 'int' is not allowed in a converted constant expression}} | ||
| */ | ||
| case 10 ... "a": break; /* c-expected-error {{integer constant expression must have integer type, not 'char[2]'}} | ||
| cxx-expected-error {{value of type 'const char[2]' is not implicitly convertible to 'int'}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| } | ||
|
|
||
| switch (i) { | ||
| // Cannot have multiple cases covering the same value. | ||
| // FIXME: diagnostic quality here is poor. The "previous case" note is | ||
| // showing up on a subsequent line (I'd expect the error and note to be | ||
| // reversed), and "duplicate case value 20" is showing up on a line where | ||
| // there is no duplicate value 20 to begin with. | ||
| case 10 ... 20: break; /* expected-error {{duplicate case value '11'}} | ||
| expected-note {{previous case defined here}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| case 11: break; /* expected-note {{previous case defined here}} | ||
| */ | ||
| case 11 ... 14: break; /* expected-error {{duplicate case value '20'}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| } | ||
|
|
||
| // The values specified by the range shall not change as a result of | ||
| // conversion to the promoted type of the controlling expression. | ||
| // FIXME: the overflow warnings seem like they probably should also trigger | ||
| // in C++ as they do in C. | ||
| switch ((unsigned char)i) { | ||
| case 254 ... 256: break; /* c-expected-warning {{overflow converting case value to switch condition type (256 to 0)}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| case 257 ... 258: break; /* c-expected-warning {{overflow converting case value to switch condition type (257 to 1)}} | ||
| c-expected-warning {{overflow converting case value to switch condition type (258 to 2)}} | ||
| gnu-warning {{case ranges are a GNU extension}} | ||
| ped-warning {{case ranges are a C2y extension}} | ||
| pre-warning {{case ranges are incompatible with C standards before C2y}} | ||
| */ | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my :)