-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[libc][math][c23] Add tanpif16 function #115183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2a64451
add tanpif16 function
wldfngrs 0a27bd5
mend
wldfngrs 4edcddd
Add implementation of tanpi for MPFR < 4.2
wldfngrs d89dbaf
mend
wldfngrs 0810591
update documentation
wldfngrs c1b926b
Fixed failed remote build (changed 'mpfr_fmod_ui()' to 'mpfr_fmod()')
wldfngrs 7d71a09
minor fix
wldfngrs f81198b
more fix
wldfngrs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| //===-- Half-precision tanpif function ------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "src/math/tanpif16.h" | ||
| #include "hdr/errno_macros.h" | ||
| #include "hdr/fenv_macros.h" | ||
| #include "sincosf16_utils.h" | ||
| #include "src/__support/FPUtil/FEnvImpl.h" | ||
| #include "src/__support/FPUtil/FPBits.h" | ||
| #include "src/__support/FPUtil/cast.h" | ||
| #include "src/__support/FPUtil/except_value_utils.h" | ||
| #include "src/__support/FPUtil/multiply_add.h" | ||
| #include "src/__support/macros/optimization.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
|
|
||
| constexpr size_t N_EXCEPTS = 21; | ||
|
|
||
| constexpr fputil::ExceptValues<float16, N_EXCEPTS> TANF16_EXCEPTS{{ | ||
| // (input, RZ output, RU offset, RD offset, RN offset) | ||
| {0x07f2, 0x0e3d, 1, 0, 0}, {0x086a, 0x0eee, 1, 0, 1}, | ||
| {0x08db, 0x0fa0, 1, 0, 0}, {0x094c, 0x1029, 1, 0, 0}, | ||
| {0x0b10, 0x118c, 1, 0, 0}, {0x1ce0, 0x23a8, 1, 0, 1}, | ||
| {0x1235, 0x18e0, 1, 0, 0}, {0x2579, 0x2c4e, 1, 0, 0}, | ||
| {0x28b2, 0x2f68, 1, 0, 1}, {0x2a43, 0x30f4, 1, 0, 1}, | ||
| {0x31b7, 0x3907, 1, 0, 0}, {0x329d, 0x3a12, 1, 0, 1}, | ||
| {0x34f1, 0x3dd7, 1, 0, 0}, {0x3658, 0x41ee, 1, 0, 0}, | ||
| {0x38d4, 0xc1ee, 0, 1, 0}, {0x3d96, 0x41ee, 1, 0, 0}, | ||
| {0x3e6a, 0xc1ee, 0, 1, 0}, {0x40cb, 0x41ee, 1, 0, 0}, | ||
| {0x4135, 0xc1ee, 0, 1, 0}, {0x42cb, 0x41ee, 1, 0, 0}, | ||
| {0x4335, 0xc1ee, 0, 1, 0}, | ||
| }}; | ||
|
|
||
| LLVM_LIBC_FUNCTION(float16, tanpif16, (float16 x)) { | ||
| using FPBits = typename fputil::FPBits<float16>; | ||
| FPBits xbits(x); | ||
|
|
||
| uint16_t x_u = xbits.uintval(); | ||
| bool x_sign = x_u >> 15; | ||
| uint16_t x_abs = x_u & 0x7fff; | ||
|
|
||
| if (LIBC_UNLIKELY(x_abs == 0U)) | ||
| return x; | ||
|
|
||
| // Handle exceptional values | ||
| if (LIBC_UNLIKELY(x_abs <= 0x4335)) { | ||
| if (auto r = TANF16_EXCEPTS.lookup_odd(x_abs, x_sign); | ||
| LIBC_UNLIKELY(r.has_value())) | ||
| return r.value(); | ||
| } | ||
|
|
||
| // Numbers greater or equal to 2^10 are integers, or infinity, or NaN | ||
| if (LIBC_UNLIKELY(x_abs >= 0x6400)) { | ||
| // Check for NaN or infinity values | ||
| if (LIBC_UNLIKELY(x_abs >= 0x7c00)) { | ||
| if (x_abs == 0x7c00) { | ||
| fputil::set_errno_if_required(EDOM); | ||
| fputil::raise_except_if_required(FE_INVALID); | ||
| } | ||
|
|
||
| return x + FPBits::quiet_nan().get_val(); | ||
| } | ||
|
|
||
| return FPBits::zero(xbits.sign()).get_val(); | ||
| } | ||
| // Range reduction: | ||
| // For |x| > 1/32, we perform range reduction as follows: | ||
| // Find k and y such that: | ||
| // x = (k + y) * 1/32 | ||
| // k is an integer | ||
| // |y| < 0.5 | ||
| // | ||
| // This is done by performing: | ||
| // k = round(x * 32) | ||
| // y = x * 32 - k | ||
| // | ||
| // Once k and y are computed, we then deduce the answer by tthe formula: | ||
| // tan(x) = sin(x) / cos(x) | ||
| // = (sin_y * cos_k + cos_y * sin_k) / (cos_y * cos_k - sin_y * sin_k) | ||
| float xf = x; | ||
| float sin_k, cos_k, sin_y, cosm1_y; | ||
| sincospif16_eval(xf, sin_k, cos_k, sin_y, cosm1_y); | ||
|
|
||
| if (LIBC_UNLIKELY(sin_y == 0 && cos_k == 0)) { | ||
| fputil::set_errno_if_required(EDOM); | ||
| fputil::raise_except_if_required(FE_DIVBYZERO); | ||
|
|
||
| int16_t x_mp5_u = static_cast<int16_t>(x - 0.5); | ||
| return ((x_mp5_u & 0x1) ? -1 : 1) * FPBits::inf().get_val(); | ||
| } | ||
|
|
||
| using fputil::multiply_add; | ||
| return fputil::cast<float16>( | ||
| multiply_add(sin_y, cos_k, multiply_add(cosm1_y, sin_k, sin_k)) / | ||
| multiply_add(sin_y, -sin_k, multiply_add(cosm1_y, cos_k, cos_k))); | ||
| } | ||
|
|
||
| } // namespace LIBC_NAMESPACE_DECL | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| //===-- Implementation header for tanpif16 ----------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC_MATH_TANPIF16_H | ||
| #define LLVM_LIBC_SRC_MATH_TANPIF16_H | ||
|
|
||
| #include "src/__support/macros/config.h" | ||
| #include "src/__support/macros/properties/types.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
|
|
||
| float16 tanpif16(float16 x); | ||
|
|
||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC_MATH_TANPIF16_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| //===-- Unittests for tanpif16 --------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "src/errno/libc_errno.h" | ||
| #include "src/math/tanpif16.h" | ||
| #include "test/UnitTest/FPMatcher.h" | ||
| #include "test/UnitTest/Test.h" | ||
|
|
||
| using LlvmLibcTanpif16Test = LIBC_NAMESPACE::testing::FPTest<float16>; | ||
|
|
||
| TEST_F(LlvmLibcTanpif16Test, SpecialNumbers) { | ||
| LIBC_NAMESPACE::libc_errno = 0; | ||
|
|
||
| EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::tanpif16(aNaN)); | ||
| EXPECT_MATH_ERRNO(0); | ||
|
|
||
| EXPECT_FP_EQ(zero, LIBC_NAMESPACE::tanpif16(zero)); | ||
| EXPECT_MATH_ERRNO(0); | ||
|
|
||
| EXPECT_FP_EQ(neg_zero, LIBC_NAMESPACE::tanpif16(neg_zero)); | ||
| EXPECT_MATH_ERRNO(0); | ||
|
|
||
| EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::tanpif16(inf)); | ||
| EXPECT_MATH_ERRNO(EDOM); | ||
|
|
||
| EXPECT_FP_EQ(aNaN, LIBC_NAMESPACE::tanpif16(neg_inf)); | ||
| EXPECT_MATH_ERRNO(EDOM); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| //===-- Exhaustive test for cospif16 --------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "src/math/tanpif16.h" | ||
| #include "test/UnitTest/FPMatcher.h" | ||
| #include "test/UnitTest/Test.h" | ||
| #include "utils/MPFRWrapper/MPFRUtils.h" | ||
|
|
||
| using LlvmLibcTanpif16Test = LIBC_NAMESPACE::testing::FPTest<float16>; | ||
|
|
||
| namespace mpfr = LIBC_NAMESPACE::testing::mpfr; | ||
|
|
||
| // Range: [0, Inf] | ||
| static constexpr uint16_t POS_START = 0x0000U; | ||
| static constexpr uint16_t POS_STOP = 0x7c00U; | ||
|
|
||
| // Range: [-Inf, 0] | ||
| static constexpr uint16_t NEG_START = 0x8000U; | ||
| static constexpr uint16_t NEG_STOP = 0xfc00U; | ||
|
|
||
| TEST_F(LlvmLibcTanpif16Test, PositiveRange) { | ||
| for (uint16_t v = POS_START; v <= POS_STOP; ++v) { | ||
| float16 x = FPBits(v).get_val(); | ||
| EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Tanpi, x, | ||
| LIBC_NAMESPACE::tanpif16(x), 0.5); | ||
| } | ||
| } | ||
|
|
||
| TEST_F(LlvmLibcTanpif16Test, NegativeRange) { | ||
| for (uint16_t v = NEG_START; v <= NEG_STOP; ++v) { | ||
| float16 x = FPBits(v).get_val(); | ||
| EXPECT_MPFR_MATCH_ALL_ROUNDING(mpfr::Operation::Tanpi, x, | ||
| LIBC_NAMESPACE::tanpif16(x), 0.5); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,7 @@ enum class Operation : int { | |
| Sqrt, | ||
| Tan, | ||
| Tanh, | ||
| Tanpi, | ||
| Trunc, | ||
| EndUnaryOperationsSingleOutput, | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.