Skip to content

[InstCombine] fold sub(zext(ptrtoint),zext(ptrtoint)) #115369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2024
Merged

[InstCombine] fold sub(zext(ptrtoint),zext(ptrtoint)) #115369

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e360e21
[InstCombine] fold `sub(zext(ptrtoint),zext(ptrtoint))`
npanchen Nov 7, 2024
5c692fd
Changed pattern matching
npanchen Nov 8, 2024
a2b3e03
Addressed comments
npanchen Nov 13, 2024
fa83e47
Addressed comments
npanchen Nov 14, 2024
11090ab
Updated test
npanchen Nov 14, 2024
987bfd9
Added identical test that use non-global ptr
npanchen Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,6 +2631,18 @@ Instruction *InstCombinerImpl::visitSub(BinaryOperator &I) {
/* IsNUW */ false))
return replaceInstUsesWith(I, Res);

if (match(Op0, m_ZExt(m_PtrToInt(m_Value(LHSOp)))) &&
match(Op1, m_PtrToInt(m_Value(RHSOp))) && isa<GlobalValue>(RHSOp)) {
Value *Offset;
if (match(LHSOp, m_GEP(m_Specific(RHSOp), m_Value(Offset)))) {
auto *GEP = cast<GEPOperator>(LHSOp);
if (GEP->isInBounds()) {
Value *Res = Builder.CreateZExt(EmitGEPOffset(GEP), I.getType());
return replaceInstUsesWith(I, Res);
}
}
}

// Canonicalize a shifty way to code absolute value to the common pattern.
// There are 2 potential commuted variants.
// We're relying on the fact that we only do this transform when the shift has
Expand Down
59 changes: 58 additions & 1 deletion llvm/test/Transforms/InstCombine/sub-gep.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -S -passes=instcombine < %s | FileCheck %s

target datalayout = "e-p:64:64:64-p1:16:16:16-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target datalayout = "e-p:64:64:64-p1:16:16:16-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-p2:32:32"

define i64 @test_inbounds(ptr %base, i64 %idx) {
; CHECK-LABEL: @test_inbounds(
Expand Down Expand Up @@ -270,6 +270,36 @@ define i64 @test25(ptr %P, i64 %A){
ret i64 %G
}

define i64 @zext_ptrtoint_sub_ptrtoint(ptr %p, i32 %offset) {
; CHECK-LABEL: @zext_ptrtoint_sub_ptrtoint(
; CHECK-NEXT: %1 = sext i32 %offset to i64
; CHECK-NEXT: %A = getelementptr bfloat, ptr @Arr, i64 %1
; CHECK-NEXT: %2 = ptrtoint ptr %A to i64
; CHECK-NEXT: %C = and i64 %2, 4294967294
; CHECK-NEXT: %D = sub i64 %C, ptrtoint (ptr @Arr to i64)
; CHECK-NEXT: ret i64 %D
%A = getelementptr bfloat, ptr @Arr, i32 %offset
%B = ptrtoint ptr %A to i32
%C = zext i32 %B to i64
%D = sub i64 %C, ptrtoint (ptr @Arr to i64)
ret i64 %D
}

define i64 @ptrtoint_sub_zext_ptrtoint(ptr %p, i32 %offset) {
; CHECK-LABEL: @ptrtoint_sub_zext_ptrtoint(
; CHECK-NEXT: %1 = sext i32 %offset to i64
; CHECK-NEXT: %A = getelementptr bfloat, ptr @Arr, i64 %1
; CHECK-NEXT: %2 = ptrtoint ptr %A to i64
; CHECK-NEXT: %C = and i64 %2, 4294967294
; CHECK-NEXT: %D = sub i64 ptrtoint (ptr @Arr to i64), %C
; CHECK-NEXT: ret i64 %D
%A = getelementptr bfloat, ptr @Arr, i32 %offset
%B = ptrtoint ptr %A to i32
%C = zext i32 %B to i64
%D = sub i64 ptrtoint (ptr @Arr to i64), %C
ret i64 %D
}

@Arr_as1 = external addrspace(1) global [42 x i16]

define i16 @test25_as1(ptr addrspace(1) %P, i64 %A) {
Expand All @@ -285,6 +315,33 @@ define i16 @test25_as1(ptr addrspace(1) %P, i64 %A) {
ret i16 %G
}

@Arr_as2 = external addrspace(2) global [42 x i16]
define i64 @zext_ptrtoint_sub_ptrtoint_as2(ptr addrspace(1) %p, i32 %offset) {
; CHECK-LABEL: @zext_ptrtoint_sub_ptrtoint_as2(
; CHECK-NEXT: %A.idx = shl nsw i32 %offset, 1
; CHECK-NEXT: %D = zext i32 %A.idx to i64
; CHECK-NEXT: ret i64 %D
%A = getelementptr inbounds bfloat, ptr addrspace(2) @Arr_as2, i32 %offset
%B = ptrtoint ptr addrspace(2) %A to i32
%C = zext i32 %B to i64
%D = sub i64 %C, ptrtoint (ptr addrspace(2) @Arr_as2 to i64)
ret i64 %D
}

define i64 @ptrtoint_sub_zext_ptrtoint_as2(ptr addrspace(2) %p, i32 %offset) {
; CHECK-LABEL: @ptrtoint_sub_zext_ptrtoint_as2(
; CHECK-NEXT: %A = getelementptr inbounds bfloat, ptr addrspace(2) @Arr_as2, i32 %offset
; CHECK-NEXT: %B = ptrtoint ptr addrspace(2) %A to i32
; CHECK-NEXT: %C = zext i32 %B to i64
; CHECK-NEXT: %D = sub nsw i64 ptrtoint (ptr addrspace(2) @Arr_as2 to i64), %C
; CHECK-NEXT: ret i64 %D
%A = getelementptr inbounds bfloat, ptr addrspace(2) @Arr_as2, i32 %offset
%B = ptrtoint ptr addrspace(2) %A to i32
%C = zext i32 %B to i64
%D = sub i64 ptrtoint (ptr addrspace(2) @Arr_as2 to i64), %C
ret i64 %D
}

define i64 @test30(ptr %foo, i64 %i, i64 %j) {
; CHECK-LABEL: @test30(
; CHECK-NEXT: [[GEP1_IDX:%.*]] = shl nsw i64 [[I:%.*]], 2
Expand Down
Loading