Reland '[lineeditor] Add setHistorySize() method for adjusting history size'
#115442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajithvs
changed the title
[lineeditor] Add setHistorySize() method for adjusting history sizesetHistorySize() method for adjusting history size'
devajithvs
force-pushed
the
lineeditor
branch
2 times, most recently
from
d9237b8 to
78de578
Compare
devajithvs
force-pushed
the
lineeditor
branch
from
78de578 to
236f28b
Compare
Contributor
Author
|
Can we merge this @vgvassilev ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland: #110092
Buildbot was failing due to an unused variable warning as there were 2 implementations (with and without libedit). Compared to last version, wrap the variable inside the
#ifdef HAVE_LIBEDIT.Apologies for the oversight @vgvassilev