Skip to content

Conversation

@slydiman
Copy link
Contributor

@slydiman slydiman commented Nov 8, 2024

Fixed TestTargetCommand.py in case of Windows host and Linux target.

@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

Fixed TestTargetCommand.py in case of Windows host and Linux target.


Full diff: https://github.com/llvm/llvm-project/pull/115470.diff

1 Files Affected:

  • (modified) lldb/test/API/commands/target/basic/TestTargetCommand.py (+3-3)
diff --git a/lldb/test/API/commands/target/basic/TestTargetCommand.py b/lldb/test/API/commands/target/basic/TestTargetCommand.py
index cb7a5f33f6643e..cd4885544cf46c 100644
--- a/lldb/test/API/commands/target/basic/TestTargetCommand.py
+++ b/lldb/test/API/commands/target/basic/TestTargetCommand.py
@@ -417,7 +417,7 @@ def test_target_create_nonexistent_core_file(self):
         )
 
     # Write only files don't seem to be supported on Windows.
-    @skipIfWindows
+    @skipIf(hostoslist=['windows'])
     @no_debug_info_test
     def test_target_create_unreadable_core_file(self):
         tf = tempfile.NamedTemporaryFile()
@@ -440,7 +440,7 @@ def test_target_create_nonexistent_sym_file(self):
             ],
         )
 
-    @skipIfWindows
+    @skipIf(hostoslist=['windows'])
     @no_debug_info_test
     def test_target_create_invalid_core_file(self):
         invalid_core_path = os.path.join(self.getSourceDir(), "invalid_core_file")
@@ -451,7 +451,7 @@ def test_target_create_invalid_core_file(self):
         )
 
     # Write only files don't seem to be supported on Windows.
-    @skipIfWindows
+    @skipIf(hostoslist=['windows'])
     @no_debug_info_test
     def test_target_create_unreadable_sym_file(self):
         tf = tempfile.NamedTemporaryFile()

@github-actions
Copy link

github-actions bot commented Nov 8, 2024

✅ With the latest revision this PR passed the Python code formatter.

@slydiman slydiman force-pushed the lldb-fix-TestTargetCommand branch from 284853a to cae9690 Compare November 8, 2024 12:53
@slydiman slydiman force-pushed the lldb-fix-TestTargetCommand branch from cae9690 to e3501b2 Compare November 8, 2024 13:46
@slydiman slydiman merged commit d5677b6 into llvm:main Nov 8, 2024
5 of 6 checks passed
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
…arget (llvm#115470)

Fixed TestTargetCommand.py in case of Windows host and Linux target.
@slydiman slydiman deleted the lldb-fix-TestTargetCommand branch April 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants