[symbolizer] Change the ErrorHandler from llvm::function_ref to std::function.

[hokein]

This fixes dangling ErrorHandler references (here is an example).

llvm::function_ref doesn't own the callable, and it is not safe to store a function_ref (the PlainPrinterBase stores a llvm::function_ref which can easily lead to dangling references).

[llvmbot]

@llvm/pr-subscribers-debuginfo

Author: Haojian Wu (hokein)

Changes

This fixes dangling ErrorHandler references (here is an example).

llvm::function_ref doesn't own the callable, and it is not safe to store a function_ref (the PlainPrinterBase stores a llvm::function_ref which can easily lead to dangling references).

---

Full diff: https://github.com/llvm/llvm-project/pull/115477.diff

1 Files Affected:

• (modified) llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h (+1-1)

diff --git a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
index 72ffdd29f1b72d..828875f1bb0ede 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
@@ -65,7 +65,7 @@ struct PrinterConfig {
   int SourceContextLines;
 };
 
-using ErrorHandler = function_ref<void(const ErrorInfoBase &, StringRef)>;
+using ErrorHandler = std::function<void(const ErrorInfoBase &, StringRef)>;
 
 class PlainPrinterBase : public DIPrinter {
 protected:

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Haojian Wu (hokein)

Changes

This fixes dangling ErrorHandler references (here is an example).

llvm::function_ref doesn't own the callable, and it is not safe to store a function_ref (the PlainPrinterBase stores a llvm::function_ref which can easily lead to dangling references).

---

Full diff: https://github.com/llvm/llvm-project/pull/115477.diff

1 Files Affected:

• (modified) llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h (+1-1)

diff --git a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
index 72ffdd29f1b72d..828875f1bb0ede 100644
--- a/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
+++ b/llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
@@ -65,7 +65,7 @@ struct PrinterConfig {
   int SourceContextLines;
 };
 
-using ErrorHandler = function_ref<void(const ErrorInfoBase &, StringRef)>;
+using ErrorHandler = std::function<void(const ErrorInfoBase &, StringRef)>;
 
 class PlainPrinterBase : public DIPrinter {
 protected:

[jh7370]

LGTM.