[SandboxIR] Remove incorrect assertion. #115553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertBefore can be called on a detached instruction, and we can't check that the underlying instructions are ordered because instructions without BB parents have no order. This problem showed up as a different assertion failure in llvm::Instruction::comesBefore in one of the unit tests when EXPENSIVE_CHECKS are enabled.
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
`insertBefore` can be called on a detached instruction, and we can't check that the underlying instructions are ordered because instructions without BB parents have no order. This problem showed up as a different assertion failure in `llvm::Instruction::comesBefore` in one of the unit tests when `EXPENSIVE_CHECKS` are enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insertBeforecan be called on a detached instruction, and we can't check that the underlying instructions are ordered because instructions without BB parents have no order.This problem showed up as a different assertion failure in
llvm::Instruction::comesBeforein one of the unit tests whenEXPENSIVE_CHECKSare enabled.