Skip to content

[AArch64][GlobalISel] Do not create LIFETIME instructions in functions. #115669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[AArch64][GlobalISel] Do not create LIFETIME instructions in functions. #115669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,7 +2166,8 @@ bool IRTranslator::translateKnownIntrinsic(const CallInst &CI, Intrinsic::ID ID,
case Intrinsic::lifetime_start:
case Intrinsic::lifetime_end: {
// No stack colouring in O0, discard region information.
if (MF->getTarget().getOptLevel() == CodeGenOptLevel::None)
if (MF->getTarget().getOptLevel() == CodeGenOptLevel::None ||
MF->getFunction().hasOptNone())
Copy link
Contributor

@arsenm arsenm Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DAG doesn't check this, fix both together?

Copy link
Collaborator Author

@davemgreen davemgreen Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like DAG goes via OptLevelChanger, which sets the OptLevel and resets it after handling the function. (And forces into using fast-isel, even if we would not usually use it).

return true;

unsigned Op = ID == Intrinsic::lifetime_start ? TargetOpcode::LIFETIME_START
Expand Down
14 changes: 14 additions & 0 deletions llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,6 +1477,20 @@ define void @test_lifetime_intrin() {
ret void
}

define void @test_lifetime_intrin_optnone() optnone noinline {
; CHECK-LABEL: name: test_lifetime_intrin_optnone
; CHECK: RET_ReallyLR
; O3-LABEL: name: test_lifetime_intrin_optnone
; O3: {{%[0-9]+}}:_(p0) = G_FRAME_INDEX %stack.0.slot
; O3-NEXT: G_STORE
; O3-NEXT: RET_ReallyLR
%slot = alloca i8, i32 4
call void @llvm.lifetime.start.p0(i64 0, ptr %slot)
store volatile i8 10, ptr %slot
call void @llvm.lifetime.end.p0(i64 0, ptr %slot)
ret void
}

define void @test_load_store_atomics(ptr %addr) {
; CHECK-LABEL: name: test_load_store_atomics
; CHECK: [[ADDR:%[0-9]+]]:_(p0) = COPY $x0
Expand Down
Loading