Skip to content

Conversation

@philnik777
Copy link
Contributor

We can use __conditional_no_unique_address instead of specializating __tuple_leaf for empty non-final classes.

@philnik777 philnik777 force-pushed the simplify_tuple branch 2 times, most recently from 82b98cc to 2aac7d8 Compare November 14, 2024 13:16
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 51809e4a26a8c6db6cce115822d185fe662dc0fc f20f4b981ffb1bc438cefdb1ce8b17135d31aeb4 --extensions ,h,cpp -- libcxx/include/__utility/conditional_no_unique_address.h libcxx/include/__expected/expected.h libcxx/include/__utility/in_place.h libcxx/include/tuple libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.verify.cpp
View the diff from clang-format here.
diff --git a/libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.verify.cpp b/libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.verify.cpp
index 0f61c6b1e1..b5f86ac829 100644
--- a/libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.verify.cpp
+++ b/libcxx/test/libcxx/utilities/tuple/tuple.tuple/tuple.cnstr/PR20855_tuple_ref_binding_diagnostics.verify.cpp
@@ -38,7 +38,6 @@ template <class T> struct CannotDeduce {
 template <class ...Args>
 void F(typename CannotDeduce<std::tuple<Args...>>::type const&) {}
 
-
 void f() {
   // Test that we emit our diagnostic from the library.
   // expected-error@tuple:* 8 {{Attempted construction of reference element binds to a temporary whose lifetime has ended}}

@philnik777 philnik777 force-pushed the simplify_tuple branch 3 times, most recently from 81e6528 to 9df50a8 Compare November 17, 2024 11:12
@philnik777 philnik777 closed this Jan 27, 2025
@philnik777 philnik777 deleted the simplify_tuple branch March 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant