[CSKY] Default to unsigned char #115961
Merged
[CSKY] Default to unsigned char #115961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Alexander Richardson (arichardson) ChangesThis matches the ABI document found at Partially addresses #115957 Full diff: https://github.com/llvm/llvm-project/pull/115961.diff 2 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 0952262c360185..0476bb49e2c92e 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -1340,6 +1340,7 @@ static bool isSignedCharDefault(const llvm::Triple &Triple) {
return true;
return false;
+ case llvm::Triple::csky:
case llvm::Triple::hexagon:
case llvm::Triple::ppcle:
case llvm::Triple::ppc64le:
diff --git a/clang/test/Driver/csky-toolchain.c b/clang/test/Driver/csky-toolchain.c
index 66485464652ac8..638ce64ec98cde 100644
--- a/clang/test/Driver/csky-toolchain.c
+++ b/clang/test/Driver/csky-toolchain.c
@@ -3,6 +3,7 @@
// RUN: %clang -### %s --target=csky 2>&1 | FileCheck -check-prefix=CC1 %s
// CC1: "-cc1" "-triple" "csky"
+// CC1: "-fno-signed-char"
// In the below tests, --rtlib=platform is used so that the driver ignores
// the configure-time CLANG_DEFAULT_RTLIB option when choosing the runtime lib
|
Member
Author
|
ping |
Member
Author
|
@zixuan-wu (or anyone else who knows about CSKY) ping |
Member
Author
|
ping |
zixuan-wu
approved these changes
Feb 8, 2025
Contributor
zixuan-wu
left a comment
zixuan-wu
left a comment
There was a problem hiding this comment.
LGTM. But I think commit msg should be refined(this PR is not for upstreaming?)
Member
Author
Thanks for reviewing! |
arichardson
deleted the
users/arichardson/spr/csky-default-to-unsigned-char
branch
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 9, 2025
This matches the ABI document found at https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf Partially addresses llvm/llvm-project#115957 Reviewed By: zixuan-wu Pull Request: llvm/llvm-project#115961
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This matches the ABI document found at https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf Partially addresses llvm#115957 Reviewed By: zixuan-wu Pull Request: llvm#115961
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 21, 2025
This matches the ABI document found at https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf Partially addresses llvm/llvm-project#115957 Reviewed By: zixuan-wu Pull Request: llvm/llvm-project#115961 (cherry picked from commit d204724)
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 21, 2025
This matches the ABI document found at https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf Partially addresses llvm/llvm-project#115957 Reviewed By: zixuan-wu Pull Request: llvm/llvm-project#115961 (cherry picked from commit d204724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the ABI document found at
https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf
Partially addresses #115957