[llvm][ARM] Missing switch statement handles #116086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR llvm#115153 added enums which needed to be handled in a switch statement. This trips up buildbot. Change-Id: Ic361cffb51a0924a77adc573fe653a30fe017a42
Member
|
@llvm/pr-subscribers-backend-arm Author: Nashe Mncube (nasherm) ChangesPR #115153 added enums which needed to be handled in a switch statement. This trips up buildbot. Full diff: https://github.com/llvm/llvm-project/pull/116086.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMSubtarget.cpp b/llvm/lib/Target/ARM/ARMSubtarget.cpp
index cec44acc544377..61c7fadb20aeb7 100644
--- a/llvm/lib/Target/ARM/ARMSubtarget.cpp
+++ b/llvm/lib/Target/ARM/ARMSubtarget.cpp
@@ -292,7 +292,9 @@ void ARMSubtarget::initSubtargetFeatures(StringRef CPU, StringRef FS) {
case CortexR5:
case CortexR7:
case CortexM3:
+ case CortexM55:
case CortexM7:
+ case CortexM85:
case CortexR52:
case CortexR52plus:
case CortexX1:
|
kazutakahirata
approved these changes
Nov 13, 2024
Contributor
kazutakahirata
left a comment
kazutakahirata
left a comment
There was a problem hiding this comment.
LGTM. Thank you for quickly fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #115153 added enums which needed to be handled in a switch statement. This trips up buildbot.