Filter test based on backend support. #116244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang Author: Daniel Kiss (DanielKristofKiss) ChangesFull diff: https://github.com/llvm/llvm-project/pull/116244.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/ifunc-win.c b/clang/test/CodeGen/ifunc-win.c
index 7c9d6f6516c70f..deda51757e43be 100644
--- a/clang/test/CodeGen/ifunc-win.c
+++ b/clang/test/CodeGen/ifunc-win.c
@@ -3,6 +3,8 @@
// RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -fsanitize=thread -O2 -emit-llvm -o - %s | FileCheck %s --check-prefix=SAN
// RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -fsanitize=address -O2 -emit-llvm -o - %s | FileCheck %s --check-prefix=SAN
+// REQUIRES: aarch64-registered-target
+
int foo(int) __attribute__ ((ifunc("foo_ifunc")));
static int f1(int i) {
|
labrinea
approved these changes
Nov 14, 2024
Collaborator
labrinea
left a comment
labrinea
left a comment
There was a problem hiding this comment.
Perhaps the title meant to say "backend"? Looks good, please add a short description, or correct the title for more clarity. Thanks!
DanielKristofKiss
changed the title
AaronBallman
approved these changes
Nov 14, 2024
Collaborator
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
LGTM, it would be good to land this ASAP so the bots get back to green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifunc support for Windows on AArch64 needs AArch64 support in the backend so restrict the test to it's availability.