Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
03ca42c
safe-icf
Nov 12, 2024
237c02e
Changed icf option
Nov 15, 2024
d794fb0
addressed comments
Nov 15, 2024
6e853ca
Added four tests for pic/no-pic mode. Tests for global const function…
Nov 16, 2024
e36ec02
switched to enum version of icf compile option
Nov 16, 2024
b83c335
simplified debug print, removed shared func
Nov 20, 2024
39c7902
updated tests
Nov 20, 2024
39586b3
addressed comments
Nov 20, 2024
debeb6f
updated icf option descriptions
Nov 20, 2024
429075e
moved getRelocation* to Relocs.cpp
Nov 20, 2024
29cc466
moved code around
Nov 20, 2024
bf3bf2b
simplified assembly
Nov 22, 2024
e867900
changed comment
Nov 22, 2024
ab51077
consolidate main/helper assembly under main. Next step move to test t…
Nov 25, 2024
8fe4b3c
move assembly into test
Nov 26, 2024
dc41c58
removed some lines from assembly
Nov 26, 2024
6287a7f
removed comments, changed demangled names for key functions
Nov 26, 2024
c6a1965
removed .text and .file
Nov 26, 2024
d393b5e
Changed schedule strategy, cleaned up tests some more, and removed so…
Nov 30, 2024
4ace9bd
moved reloc checking code, and changed elf object from assert to retu…
Nov 30, 2024
09bc3fa
fixing formatting that was messed up due to VSC format on save gettin…
Nov 30, 2024
3912b85
some cleanup after code changes to address comments
Dec 1, 2024
769cf24
clang-format
Dec 1, 2024
d4f81c9
removed some redundant tests, re-added on more targetted one that jus…
Dec 4, 2024
ec54f24
removed one more test I missed
Dec 4, 2024
13bcc22
Changed so that general data sections are processed. Moved ICF option…
Dec 5, 2024
5110f74
Added vtable filtering, and check fo X86 architecture
Dec 6, 2024
d524ed5
moved check as first one
Dec 6, 2024
77ae0a2
fix formatter
Dec 6, 2024
d03ff1d
minor nits
Dec 10, 2024
38758ee
Removed skip and moved processInstructionForFuncReferences, nits
Dec 10, 2024
bfb1dc6
refactor bit vector
Dec 11, 2024
417196c
nit
Dec 11, 2024
bbf015f
changed to using BinarySections, cleaned up code that is no longer ne…
Dec 13, 2024
1ef1d27
clang-format
Dec 13, 2024
f1813b3
more cleanup
Dec 13, 2024
eb882e5
addressed comments
Dec 13, 2024
f6dcb90
added comment for static relocs
Dec 13, 2024
0070ceb
Added deprecation warning, switched to SparseBitVector
Dec 14, 2024
0f96524
changed comments
Dec 16, 2024
a9cd467
more cleanup
Dec 16, 2024
6a89d5c
addressed comments
Dec 17, 2024
645aac2
small change to comment
Dec 17, 2024
23ea76b
changed comments for HasAddressTaken
Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bolt/lib/Core/BinaryFunction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,7 @@ void BinaryFunction::analyzeInstructionForFuncReference(const MCInst &Inst) {
if (Expr.getKind() != MCExpr::SymbolRef)
continue;
const MCSymbol &Symbol = cast<MCSymbolRefExpr>(Expr).getSymbol();
// Setting HasAdressTaken for a function regardless ICF level.
// Set HasAdressTaken for a function regardless of the ICF level.
if (BinaryFunction *BF = BC.getFunctionForSymbol(&Symbol))
BF->setHasAddressTaken(true);
}
Expand Down
Loading