[Mips] Reduce number of selectVSplatUimm/Simm functions by using templates. #116475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lates. The implementaton of methods only vary by what arguments they pass to selectVSplatCommon. Turn selectVSplatCommon into a virtual function and use template methods in the base class to pass the immediate size.
dtcxzyw
reviewed
Nov 16, 2024
|
|
||
| def vsplati8_uimm3 : SplatComplexPattern<vsplat_uimm3, v16i8, 1, | ||
| "selectVSplatUimm3", | ||
| "selectVSplatUimm<3>", |
Member
There was a problem hiding this comment.
We can further reduce duplicate code with foreach:
foreach I = {2, 4, 5, 8} in
ef vsplati8_uimm # I : SplatComplexPattern<vsplat_uimm # I, v16i8, 1,
"selectVSplatUimm<"# I #">",
Up to you.
Collaborator
Author
There was a problem hiding this comment.
I might do some other refactorings here. I'm not sure we need one of these for every element size.
devin-ai-integration bot
pushed a commit
to ohhmm/llvm-project
that referenced
this pull request
Nov 17, 2024
…lates. (llvm#116475) The implementaton of methods only vary by what arguments they pass to selectVSplatCommon. Turn selectVSplatCommon into a virtual function and use template methods in the base class to pass the immediate size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementaton of methods only vary by what arguments they pass to selectVSplatCommon.
Turn selectVSplatCommon into a virtual function and use template methods in the base class to pass the immediate size.