Skip to content

[libc++] Avoid including all of <thread> in <future> #116541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[libc++] Avoid including all of <thread> in <future> #116541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libcxx/include/future
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ template <class R, class Alloc> struct uses_allocator<packaged_task<R>, Alloc>;
# include <__system_error/error_category.h>
# include <__system_error/error_code.h>
# include <__system_error/error_condition.h>
# include <__thread/thread.h>
# include <__type_traits/add_lvalue_reference.h>
# include <__type_traits/aligned_storage.h>
# include <__type_traits/conditional.h>
Expand All @@ -397,7 +398,6 @@ template <class R, class Alloc> struct uses_allocator<packaged_task<R>, Alloc>;
# include <mutex>
# include <new>
# include <stdexcept>
# include <thread>
# include <version>

# if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
Expand Down Expand Up @@ -2071,6 +2071,7 @@ _LIBCPP_POP_MACROS
# include <exception>
# include <iosfwd>
# include <system_error>
# include <thread>
#endif

#endif // _LIBCPP_FUTURE
3 changes: 0 additions & 3 deletions libcxx/test/libcxx/transitive_includes/cxx23.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,6 @@ functional tuple
functional typeinfo
functional unordered_map
functional version
future array
future atomic
future bitset
future cctype
future cerrno
Expand Down Expand Up @@ -475,7 +473,6 @@ future stdexcept
future streambuf
future string
future string_view
future thread
future tuple
future typeinfo
future version
Expand Down
3 changes: 0 additions & 3 deletions libcxx/test/libcxx/transitive_includes/cxx26.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,6 @@ functional tuple
functional typeinfo
functional unordered_map
functional version
future array
future atomic
future bitset
future cctype
future cerrno
Expand Down Expand Up @@ -474,7 +472,6 @@ future stdexcept
future streambuf
future string
future string_view
future thread
future tuple
future typeinfo
future version
Expand Down
1 change: 1 addition & 0 deletions libcxx/test/std/thread/futures/futures.async/async.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <chrono>
#include <future>
#include <memory>
#include <thread>

#include "test_macros.h"

Expand Down
Loading