[clang-tidy][NFC]remove deps of clang in clang tidy test #116588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is introduced in https://reviews.llvm.org/D59528, but I don't find any usage of clang in clang tidy test.
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) ChangesIt is introduced in https://reviews.llvm.org/D59528, but I don't find any usage of clang in clang tidy test. Full diff: https://github.com/llvm/llvm-project/pull/116588.diff 1 Files Affected:
diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
index d72a117166a08b..7e4d99d8cfc1d3 100644
--- a/clang-tools-extra/test/CMakeLists.txt
+++ b/clang-tools-extra/test/CMakeLists.txt
@@ -50,8 +50,6 @@ set(CLANG_TOOLS_TEST_DEPS
clang-resource-headers
clang-tidy
- # Clang-tidy tests need clang for building modules.
- clang
)
# Add lit test dependencies.
|
AaronBallman
approved these changes
Nov 20, 2024
Collaborator
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
Presuming all tests continue to pass, this LGTM!
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3680 Here is the relevant piece of the build log for the reference |
Contributor
Unrelated timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is introduced in https://reviews.llvm.org/D59528, but I don't find any usage of clang in clang tidy test.