Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/tools/amdgpu-arch/AMDGPUArch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ static void PrintVersion(raw_ostream &OS) {
OS << clang::getClangToolFullVersion("amdgpu-arch") << '\n';
}

int printGPUsByHSA();
int printGPUsByKFD();
int printGPUsByHIP();

int main(int argc, char *argv[]) {
Expand All @@ -45,7 +45,7 @@ int main(int argc, char *argv[]) {
}

#ifndef _WIN32
if (!printGPUsByHSA())
if (!printGPUsByKFD())
return 0;
#endif

Expand Down
122 changes: 0 additions & 122 deletions clang/tools/amdgpu-arch/AMDGPUArchByHSA.cpp

This file was deleted.

74 changes: 74 additions & 0 deletions clang/tools/amdgpu-arch/AMDGPUArchByKFD.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
//===- AMDGPUArchByKFD.cpp - list AMDGPU installed ------*- C++ -*---------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This file implements a tool for detecting name of AMD GPUs installed in
// system using the Linux sysfs interface for the AMD KFD driver.
//
//===----------------------------------------------------------------------===//

#include "llvm/Support/FileSystem.h"
#include "llvm/Support/LineIterator.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/Path.h"
#include <memory>
#include <string>

using namespace llvm;

constexpr const char *KFD_SYSFS_NODE_PATH =
"/sys/devices/virtual/kfd/kfd/topology/nodes";

constexpr static long getMajor(long Ver) { return (Ver / 10000) % 100; }
constexpr static long getMinor(long Ver) { return (Ver / 100) % 100; }
constexpr static long getStep(long Ver) { return Ver % 100; }

int printGPUsByKFD() {
SmallVector<std::pair<long, long>> Devices;
std::error_code EC;
for (sys::fs::directory_iterator Begin(KFD_SYSFS_NODE_PATH, EC), End;
Begin != End; Begin.increment(EC)) {
if (EC)
return 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should print some errors when this fails

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure if I should, since we can still fall back to HIP in the current implementation.


long Node = 0;
if (sys::path::stem(Begin->path()).consumeInteger(10, Node))
return 1;

SmallVector<char> Path(Begin->path().begin(), Begin->path().end());
sys::path::append(Path, "properties");

ErrorOr<std::unique_ptr<MemoryBuffer>> BufferOrErr =
MemoryBuffer::getFileOrSTDIN(Path);
if (std::error_code EC = BufferOrErr.getError())
return 1;

long GFXVersion = 0;
for (line_iterator Lines(**BufferOrErr, false); !Lines.is_at_end();
++Lines) {
if (Lines->starts_with("gfx_target_version")) {
if (Lines->drop_front(sizeof("gfx_target_version"))
.consumeInteger(10, GFXVersion))
return 1;
break;
}
}

// If this is zero the node is a CPU.
if (GFXVersion == 0)
continue;
Devices.emplace_back(Node, GFXVersion);
}

// Sort the devices by their node to make sure it prints in order.
llvm::sort(Devices, [](auto &L, auto &R) { return L.first < R.first; });
for (const auto &[Node, GFXVersion] : Devices)
std::fprintf(stdout, "gfx%ld%ld%lx\n", getMajor(GFXVersion),
getMinor(GFXVersion), getStep(GFXVersion));

return 0;
}
2 changes: 1 addition & 1 deletion clang/tools/amdgpu-arch/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@

set(LLVM_LINK_COMPONENTS Support)

add_clang_tool(amdgpu-arch AMDGPUArch.cpp AMDGPUArchByHSA.cpp AMDGPUArchByHIP.cpp)
add_clang_tool(amdgpu-arch AMDGPUArch.cpp AMDGPUArchByKFD.cpp AMDGPUArchByHIP.cpp)

target_link_libraries(amdgpu-arch PRIVATE clangBasic)
Loading