Skip to content

Conversation

@maniatic0
Copy link
Contributor

@maniatic0 maniatic0 commented Nov 19, 2024

Fixed OpenMP build issue when building Wasm using Emscripten in Windows, as raised in #116552, with the proposed solution at #116552 (comment)

Adds the --target-system-override flag to message-converter.py to handle the case where the target system is not the host system. Useful when compiling with Emscripten in Windows, as Python detects the host system as the target system by default when it should be Emscripten.

Sets the use of the previous functionality in \openmp\runtime\src\CMakeLists.txt when compiling with Emscripten to solve the issue raised at #116552

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Nov 19, 2024
@jhuber6 jhuber6 requested review from jpeyton52 and shiltian and removed request for jpeyton52 November 19, 2024 20:49
@github-actions
Copy link

github-actions bot commented Nov 19, 2024

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me.

@maniatic0
Copy link
Contributor Author

Thanks! As I don't have write access, could I ask for this PR to be merged?

@shiltian shiltian merged commit 05bcf83 into llvm:main Nov 20, 2024
6 checks passed
@github-actions
Copy link

@maniatic0 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants