Skip to content

[mlir][test] Add unittests for getInversePermutation #116945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[mlir][test] Add unittests for getInversePermutation #116945

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d41db6
[mlir][test] Add unittests for `getInversePermutation`
banach-space Nov 20, 2024
ed5aab1
fixup! [mlir][test] Add unittests for `getInversePermutation`
banach-space Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions mlir/unittests/IR/AffineMapTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,39 @@ TEST(AffineMapTest, isProjectedPermutation) {
AffineMap map10 = AffineMap::get(6, 0, {d5, d3, d2, d4}, &ctx);
EXPECT_TRUE(map10.isProjectedPermutation());
}

TEST(AffineMapTest, getInversePermutation) {
MLIRContext ctx;
OpBuilder b(&ctx);

// 0. Empty map
AffineMap map0 = AffineMap::get(0, 0, {}, &ctx);
AffineMap inverseMap0 = inversePermutation(map0);
EXPECT_TRUE(inverseMap0.isEmpty());

auto d0 = b.getAffineDimExpr(0);
auto d1 = b.getAffineDimExpr(1);
auto d2 = b.getAffineDimExpr(2);

// 1. (d0, d1, d2) -> (d1, d1, d0, d2, d1, d2, d1, d0)
AffineMap map1 = AffineMap::get(3, 0, {d1, d1, d0, d2, d1, d2, d1, d0}, &ctx);
// (d0, d1, d2, d3, d4, d5, d6, d7) -> (d2, d0, d3)
AffineMap inverseMap1 = inversePermutation(map1);
auto resultsInv1 = inverseMap1.getResults();
EXPECT_EQ(resultsInv1.size(), 3UL);
EXPECT_TRUE(resultsInv1[0].isFunctionOfDim(2));
Copy link
Contributor

@javedabsar1 javedabsar1 Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check this instead of fully trusting me. But I think in case of isFunctionOfDim, d2 has to appear somewhere in the expression e.g. d2+d1 would work, and so is a less restrictive ask then if we are really check d2 and only `d2.

  auto expr = llvm::dyn_cast<AffineDimExpr>(resultsInv1[0]);
   if (!expr)  EXPECT_EQ(0,1);
  EXPECT_EQ(expr.getPosition(), 2)

Copy link
Contributor Author

@banach-space banach-space Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great point and I really appreciate the suggestion. In fact, I wasn't sure how to do it :) That's now been incorporated.

EXPECT_TRUE(resultsInv1[1].isFunctionOfDim(0));
EXPECT_TRUE(resultsInv1[2].isFunctionOfDim(3));

// 2. (d0, d1, d2) -> (d1, d0 + d1, d0, d2, d1, d2, d1, d0)
auto sum = d0 + d1;
AffineMap map2 =
AffineMap::get(3, 0, {d1, sum, d0, d2, d1, d2, d1, d0}, &ctx);
// (d0, d1, d2, d3, d4, d5, d6, d7) -> (d2, d0, d3)
AffineMap inverseMap2 = inversePermutation(map2);
auto resultsInv2 = inverseMap2.getResults();
EXPECT_EQ(resultsInv2.size(), 3UL);
EXPECT_TRUE(resultsInv1[0].isFunctionOfDim(2));
EXPECT_TRUE(resultsInv1[1].isFunctionOfDim(0));
EXPECT_TRUE(resultsInv1[2].isFunctionOfDim(3));
}
Loading