-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[LLD][ARM] Allow R_ARM_SBREL32 relocations in debug info #116956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // REQUIRES: arm | ||
| // RUN: rm -rf %t && split-file %s %t && cd %t | ||
|
|
||
| // RUN: llvm-mc -filetype=obj -triple=armv7a asm.s -o obj.o | ||
| // RUN: ld.lld -T lds.ld obj.o -o exe.elf 2>&1 | FileCheck %s --implicit-check-not=warning: --allow-empty | ||
| // RUN: llvm-objdump -D exe.elf | FileCheck --check-prefix=DISASM %s | ||
|
|
||
| // DISASM-LABEL: <rw>: | ||
| // DISASM-NEXT: 1000: 0000002a | ||
|
|
||
| // DISASM-LABEL: <rw2>: | ||
| // DISASM-NEXT: 2000: 000004d2 | ||
|
|
||
| // DISASM-LABEL: <.debug_something>: | ||
| // DISASM-NEXT: 0: 00001000 | ||
| // DISASM-NEXT: ... | ||
| // DISASM-NEXT: 104: 00002000 | ||
|
|
||
| /// Test that R_ARM_SBREL32 relocations in debug info are relocated as if the | ||
|
||
| /// static base register (r9) is zero. Real DWARF info will use an expression to | ||
| /// add this to the real value of the static base at runtime. | ||
|
|
||
| //--- lds.ld | ||
| SECTIONS { | ||
| data1 0x1000 : { *(data1) } | ||
| data2 0x2000 : { *(data2) } | ||
| } | ||
|
|
||
| //--- asm.s | ||
| .text | ||
| .type _start,%function | ||
|
||
| .globl _start | ||
| _start: | ||
| bx lr | ||
| .size _start, .-_start | ||
|
|
||
| .section data1, "aw", %progbits | ||
| .type rw,%object | ||
| .globl rw | ||
| rw: | ||
| .long 42 | ||
| .size rw, 4 | ||
|
|
||
| .section data2, "aw", %progbits | ||
| .type rw2,%object | ||
| .globl rw2 | ||
| rw2: | ||
| .long 1234 | ||
| .size rw2, 4 | ||
|
|
||
| .section .debug_something, "", %progbits | ||
| .long rw(sbrel) | ||
| .space 0x100 | ||
| .long rw2(sbrel) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(In the future, we should move relocateNonAlloc to be target-specific into Arch/ )