Skip to content

[LoongArch] Support parsing register names in CFI instructions #117120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[LoongArch] Support parsing register names in CFI instructions #117120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions llvm/lib/Target/LoongArch/AsmParser/LoongArchAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,13 +669,33 @@ static bool matchRegisterNameHelper(MCRegister &RegNo, StringRef Name) {

bool LoongArchAsmParser::parseRegister(MCRegister &Reg, SMLoc &StartLoc,
SMLoc &EndLoc) {
return Error(getLoc(), "invalid register number");
if (!tryParseRegister(Reg, StartLoc, EndLoc).isSuccess())
return Error(getLoc(), "invalid register name");

if (!LoongArchMCRegisterClasses[LoongArch::GPRRegClassID].contains(Reg) &&
!LoongArchMCRegisterClasses[LoongArch::FPR32RegClassID].contains(Reg))
return Error(getLoc(), "invalid register name");

return false;
}

ParseStatus LoongArchAsmParser::tryParseRegister(MCRegister &Reg,
SMLoc &StartLoc,
SMLoc &EndLoc) {
llvm_unreachable("Unimplemented function.");
const AsmToken &Tok = getParser().getTok();
StartLoc = Tok.getLoc();
EndLoc = Tok.getEndLoc();

parseOptionalToken(AsmToken::Dollar);
if (getLexer().getKind() != AsmToken::Identifier)
return ParseStatus::NoMatch;

StringRef Name = Tok.getIdentifier();
if (matchRegisterNameHelper(Reg, Name))
return ParseStatus::NoMatch;

getParser().Lex(); // Eat identifier token.
return ParseStatus::Success;
}

bool LoongArchAsmParser::classifySymbolRef(const MCExpr *Expr,
Expand Down
40 changes: 28 additions & 12 deletions llvm/test/MC/LoongArch/Directives/cfi.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
## Test cfi directives.

# RUN: llvm-mc %s --triple=loongarch32 | FileCheck %s
# RUN: llvm-mc %s --triple=loongarch64 | FileCheck %s
# RUN: not llvm-mc --triple=loongarch32 --defsym=ERR=1 < %s 2>&1 \
# RUN: llvm-mc %s --triple=loongarch32 --mattr=+lasx | FileCheck %s
# RUN: llvm-mc %s --triple=loongarch64 --mattr=+lasx | FileCheck %s
# RUN: not llvm-mc --triple=loongarch32 --mattr=+lasx --defsym=ERR=1 < %s 2>&1 \
# RUN: | FileCheck %s --check-prefix=CHECK-ERR
# RUN: not llvm-mc --triple=loongarch64 --defsym=ERR=1 < %s 2>&1 \
# RUN: not llvm-mc --triple=loongarch64 --mattr=+lasx --defsym=ERR=1 < %s 2>&1 \
# RUN: | FileCheck %s --check-prefix=CHECK-ERR

# CHECK: .cfi_startproc
Expand All @@ -15,20 +15,36 @@
.cfi_offset 9, 8
# CHECK-NEXT: .cfi_offset 31, 16
.cfi_offset 31, 16
# CHECK-NEXT: .cfi_offset 22, -8
.cfi_offset r22, -8
# CHECK-NEXT: .cfi_offset 22, -8
.cfi_offset $r22, -8
# CHECK-NEXT: .cfi_offset 22, -8
.cfi_offset fp, -8
# CHECK-NEXT: .cfi_offset 22, -8
.cfi_offset $fp, -8
# CHECK-NEXT: .cfi_offset 42, 8
.cfi_offset f10, 8
# CHECK-NEXT: .cfi_offset 56, 8
.cfi_offset fs0, 8
# CHECK-NEXT: .cfi_endproc
.cfi_endproc

.ifdef ERR
.cfi_startproc
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register number
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register name
.cfi_offset -22, -8
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register number
.cfi_offset fp, -8
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register number
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register name
.cfi_offset lr, -8
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register name
.cfi_offset r32, -8
# CHECK-ERR: :[[#@LINE+1]]:14: error: invalid register name
.cfi_offset $r32, -8
# CHECK-ERR: :[[#@LINE+1]]:14: error: invalid register name
.cfi_offset $22, -8
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register number
.cfi_offset $r22, -8
# CHECK-ERR: :[[#@LINE+1]]:13: error: invalid register number
.cfi_offset $fp, -8
# CHECK-ERR: :[[#@LINE+1]]:16: error: invalid register name
.cfi_offset vr0, 8
# CHECK-ERR: :[[#@LINE+1]]:16: error: invalid register name
.cfi_offset xr0, 8
.cfi_endproc
.endif
Loading