AMDGPU: Fix mfma scale source legalization #117238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code inside assert changes the variable instead of the comparison.
arsenm
force-pushed
the
users/arsenm/gfx950/fix-mfma-source-check
branch
from
c806c3c to
7565159
Compare
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesCode inside assert changes the variable instead of the comparison. Change-Id: I6054f152b551af80499f8a4597ac462f7bb0d383 Full diff: https://github.com/llvm/llvm-project/pull/117238.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 1406938592b2cb..e520dfff1016b2 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -15462,9 +15462,8 @@ void SITargetLowering::AdjustInstrPostInstrSelection(MachineInstr &MI,
int Src0Idx = AMDGPU::getNamedOperandIdx(MI.getOpcode(),
AMDGPU::OpName::scale_src0);
if (Src0Idx != -1) {
- int Src1Idx = Src0Idx + 2;
- assert(Src1Idx = AMDGPU::getNamedOperandIdx(
- MI.getOpcode(), AMDGPU::OpName::scale_src1));
+ int Src1Idx = AMDGPU::getNamedOperandIdx(MI.getOpcode(),
+ AMDGPU::OpName::scale_src1);
if (TII->usesConstantBus(MRI, MI, Src0Idx) &&
TII->usesConstantBus(MRI, MI, Src1Idx))
TII->legalizeOpWithMove(MI, Src1Idx);
|
Contributor
|
Do we need ChangeId here? |
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 17, 2025
Code inside assert changes the variable instead of the comparison. Co-authored-by: Stanislav Mekhanoshin <[email protected]> (cherry picked from commit bd8a953)
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code inside assert changes the variable instead of the comparison.