Skip to content

Conversation

@kuilpd
Copy link
Contributor

@kuilpd kuilpd commented Nov 22, 2024

Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name.
#117168

@llvmbot
Copy link
Member

llvmbot commented Nov 22, 2024

@llvm/pr-subscribers-backend-aarch64

@llvm/pr-subscribers-lldb

Author: Ilia Kuklin (kuilpd)

Changes

Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name.
#117168


Full diff: https://github.com/llvm/llvm-project/pull/117336.diff

1 Files Affected:

  • (modified) lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c (+5-5)
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..75cd4e6a913b9c 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -7,7 +7,7 @@
 
 // RUN: %clang_host -O3 -gdwarf %s -o %t
 // RUN: %lldb %t \
-// RUN:   -o "b 25" \
+// RUN:   -o "b done" \
 // RUN:   -o "r" \
 // RUN:   -o "p/x array[2]" \
 // RUN:   -b | FileCheck %s
@@ -17,10 +17,10 @@
 
 static char array[5] = {0, 1, 2, 3, 4};
 
-void func() __attribute__((noinline));
-void func() { ++array[2]; };
+int done() __attribute__((noinline));
+int done() { return array[2]; };
 
 int main(void) {
-  func();
-  return 0;
+  ++array[2];
+  return done();
 }

@llvmbot
Copy link
Member

llvmbot commented Nov 22, 2024

@llvm/pr-subscribers-platform-windows

Author: Ilia Kuklin (kuilpd)

Changes

Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name.
#117168


Full diff: https://github.com/llvm/llvm-project/pull/117336.diff

1 Files Affected:

  • (modified) lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c (+5-5)
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..75cd4e6a913b9c 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -7,7 +7,7 @@
 
 // RUN: %clang_host -O3 -gdwarf %s -o %t
 // RUN: %lldb %t \
-// RUN:   -o "b 25" \
+// RUN:   -o "b done" \
 // RUN:   -o "r" \
 // RUN:   -o "p/x array[2]" \
 // RUN:   -b | FileCheck %s
@@ -17,10 +17,10 @@
 
 static char array[5] = {0, 1, 2, 3, 4};
 
-void func() __attribute__((noinline));
-void func() { ++array[2]; };
+int done() __attribute__((noinline));
+int done() { return array[2]; };
 
 int main(void) {
-  func();
-  return 0;
+  ++array[2];
+  return done();
 }

@kuilpd kuilpd merged commit 720a4c7 into llvm:main Nov 22, 2024
11 checks passed
kuilpd added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants