Skip to content

[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script. #117342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script. #117342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions clang/tools/clang-shlib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@ add_clang_library(clang-cpp
${_OBJECTS}
LINK_LIBS
${_DEPS})
# AIX linker does not support version script
if (NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
configure_file(simple_version_script.map.in simple_version_script.map)

configure_file(simple_version_script.map.in simple_version_script.map)

if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
Copy link
Member

@aaronpuchert aaronpuchert Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX", hence the target_link_options is already unreachable.

Copy link
Contributor

@xingxue-ibm xingxue-ibm Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, @aaronpuchert! With commit eaa0a21 the AIX build problem is fixed already so the change in #117342 does not make sense any more. I created PR Revert "[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script.".

target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
endif()
endif()

# Optimize function calls for default visibility definitions to avoid PLT and
Expand Down
Loading