Skip to content

[clang][codegen] Mention the invariant that LLVM demangler should be … #117346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaNuo merged 3 commits into from
Nov 25, 2024
Merged

[clang][codegen] Mention the invariant that LLVM demangler should be … #117346

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abd3c27
[clang][codegen] Mention the invariant that LLVM demangler should be …
VitaNuo Nov 22, 2024
47cac54
[clang][codegen] Fix formatting
VitaNuo Nov 22, 2024
9d6a16d
[clang][codegen] Change the comment text to be more detailed on what …
VitaNuo Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2047,6 +2047,14 @@ StringRef CodeGenModule::getMangledName(GlobalDecl GD) {
GD.getWithKernelReferenceKind(KernelReferenceKind::Kernel),
ND));

// This invariant should hold true in the future.
// Prior work:
// https://discourse.llvm.org/t/rfc-clang-diagnostic-for-demangling-failures/82835/8
// https://github.com/llvm/llvm-project/issues/111345
// assert(llvm::isMangledName(MangledName) &&
Copy link
Member

@jyknight jyknight Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMangledName doesn't seem to exist?

But, also, we'd only want to validate output actually produced by Clang mangleCXXName, and not e.g. a user-written void f() asm("_ZGARBAGE"); void f() {}

Maybe we want:if ((MangledName.startswith("_Z") || MangledName.startswith("?")) & !GD->hasAttr<AsmLabelAttr>())?

Copy link
Contributor Author

@VitaNuo VitaNuo Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't exist. This was to demonstrate the idea.

Thanks, sure, I can change the text.

// llvm::demangle(MangledName) != MangledName &&
// "LLVM demangler must demangle clang-generated names");

auto Result = Manglings.insert(std::make_pair(MangledName, GD));
return MangledDeclNames[CanonicalGD] = Result.first->first();
}
Expand Down
Loading