Skip to content

[lldb][test] DW_OP_piece-O3.c: Disable on Windows #117355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024
Merged

[lldb][test] DW_OP_piece-O3.c: Disable on Windows #117355

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de297b6
XFAIL DW_OP_piece-O3 test on AArch64 Windows
kuilpd Nov 22, 2024
092d237
Skip the test on Windows
kuilpd Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
// DW_AT_type (0x00000032 "char[5]")
// DW_AT_location (DW_OP_piece 0x2, DW_OP_addrx 0x0, DW_OP_piece 0x1)

// XFAIL: target=aarch64-pc-windows-{{.*}}
Copy link
Contributor

@luporl luporl Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to just skip the test on windows:
// UNSUPPORTED: system-windows

At least on AArch64, debug info doesn't work with -O3 -gdwarf.

Copy link
Contributor Author

@kuilpd kuilpd Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you, good to know!

// RUN: %clang_host -O3 -gdwarf %s -o %t
// RUN: %lldb %t \
// RUN: -o "b 25" \
// RUN: -o "b 26" \
// RUN: -o "r" \
// RUN: -o "p/x array[2]" \
// RUN: -b | FileCheck %s
Expand Down
Loading