Skip to content

Make SBMemoryRegionInfoList iterable with Python SWIG #117358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Make SBMemoryRegionInfoList iterable with Python SWIG #117358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a4b65
Make SBMemeoryRegionInfoList iterable with Python SWIG
Nov 22, 2024
a6fe10a
Add unit test for SBMemoryRegionInfoList iter
Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lldb/bindings/interface/SBMemoryRegionInfoListExtensions.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@

def __iter__(self):
'''Iterate over all the memory regions in a lldb.SBMemoryRegionInfoList object.'''
return lldb_iter(self, 'GetSize', 'GetMemoryRegionAtIndex')
import lldb
size = self.GetSize()
region = lldb.SBMemoryRegionInfo()
for i in range(size):
self.GetMemoryRegionAtIndex(i, region)
yield region
Comment on lines -10 to +15
Copy link
Collaborator

@clayborg clayborg Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a getitem and repr like found in SBAddressRangeListExtensions.i:

    def __getitem__(self, idx):
      '''Get the address range at a given index in an lldb.SBAddressRangeList object.'''
      if not isinstance(idx, int):
        raise TypeError("unsupported index type: %s" % type(idx))
      count = len(self)
      if not (-count <= idx < count):
        raise IndexError("list index out of range")
      idx %= count
      return self.GetAddressRangeAtIndex(idx)

    def __repr__(self):
      import lldb
      stream = lldb.SBStream()
      self.GetDescription(stream, lldb.target if lldb.target else lldb.SBTarget())
      return stream.GetData()

%}
#endif
}
13 changes: 13 additions & 0 deletions lldb/test/API/python_api/find_in_memory/TestFindInMemory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,16 @@ def test_find_in_memory_unaligned(self):
)
self.assertSuccess(error)
self.assertEqual(addr, lldb.LLDB_INVALID_ADDRESS)

def test_memory_info_list_iterable(self):
"""Make sure the SBMemoryRegionInfoList is iterable"""
self.assertTrue(self.process, PROCESS_IS_VALID)
self.assertState(self.process.GetState(), lldb.eStateStopped, PROCESS_STOPPED)

info_list = self.process.GetMemoryRegions()
self.assertTrue(info_list.GetSize() > 0)
try:
for info in info_list:
pass
except Exception:
self.fail("SBMemoryRegionInfoList is not iterable")
Loading