Skip to content

[MLIR] Add no-inline attribute #117392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[MLIR] Add no-inline attribute #117392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fc9687
Add no-inline attribute
wsmoses Nov 22, 2024
78ecd80
update
wsmoses Dec 13, 2024
691eb77
fix
wsmoses Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mlir/lib/Dialect/Func/Extensions/InlinerExtension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,16 @@ namespace {
struct FuncInlinerInterface : public DialectInlinerInterface {
using DialectInlinerInterface::DialectInlinerInterface;

static constexpr const char* NoInlineAttrName = "noinline";
Copy link
Member

@ftynse ftynse Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, would it make sense to have this as a proper ODS attribute on FuncOp and CallOp? LLVM dialect already has one

llvm-project/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Line 1569 in cc54a0c

OptionalAttr<UnitAttr>:$no_inline,
.

Copy link
Contributor

@River707 River707 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it'd be good to integrate this directly into the dialect if possible (makes it much cleaner to target). Otherwise you're at the whims of attribute propagation.


//===--------------------------------------------------------------------===//
// Analysis Hooks
//===--------------------------------------------------------------------===//

/// All call operations can be inlined.
bool isLegalToInline(Operation *call, Operation *callable,
bool wouldBeCloned) const final {
return true;
return !call->hasAttr(NoInlineAttrName) && !callable->hasAttr(NoInlineAttrName);
}

/// All operations can be inlined.
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Transforms/inlining.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ func.func @inline_with_arg(%arg0 : i32) -> i32 {
return %0 : i32
}

// CHECK-LABEL: func @noinline_with_arg
func.func @noinline_with_arg(%arg0 : i32) -> i32 {
// CHECK-NEXT: func_with_arg
// CHECK-NEXT: return

%0 = call @func_with_arg(%arg0) {"noinline"=""} : (i32) -> i32
return %0 : i32
}

// Inline a function that has multiple return operations.
func.func @func_with_multi_return(%a : i1) -> (i32) {
cf.cond_br %a, ^bb1, ^bb2
Expand Down
Loading