Skip to content

[webkit.UncountedLambdaCapturesChecker] Ignore lambda invocation with arguments #117394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024
Merged

[webkit.UncountedLambdaCapturesChecker] Ignore lambda invocation with arguments #117394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class UncountedLambdaCapturesChecker
if (!DRE)
return;
auto *MD = dyn_cast_or_null<CXXMethodDecl>(DRE->getDecl());
if (!MD || CE->getNumArgs() != 1)
if (!MD || CE->getNumArgs() < 1)
return;
auto *Arg = CE->getArg(0)->IgnoreParenCasts();
auto *ArgRef = dyn_cast<DeclRefExpr>(Arg);
Expand Down
9 changes: 8 additions & 1 deletion clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ void noescape_lambda() {
}

void lambda_capture_param(RefCountable* obj) {
auto someLambda = [&] {
auto someLambda = [&]() {
obj->method();
};
someLambda();
Expand Down Expand Up @@ -178,3 +178,10 @@ void trivial_lambda() {
};
trivial_lambda();
}

void lambda_with_args(RefCountable* obj) {
auto trivial_lambda = [&](int v) {
obj->method();
};
trivial_lambda(1);
}
Loading