Skip to content

[lldb] Remove lldbutil.get_stack_frames (NFC) #117505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[lldb] Remove lldbutil.get_stack_frames (NFC) #117505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions lldb/packages/Python/lldbsuite/test/lldbutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,17 +1158,6 @@ def GetModuleName(i):
return list(map(GetModuleName, list(range(thread.GetNumFrames()))))


def get_stack_frames(thread):
"""
Returns a sequence of stack frames for this thread.
"""

def GetStackFrame(i):
return thread.GetFrameAtIndex(i)

return list(map(GetStackFrame, list(range(thread.GetNumFrames()))))


def print_stacktrace(thread, string_buffer=False):
"""Prints a simple stack trace of this thread."""

Expand Down
4 changes: 2 additions & 2 deletions lldb/test/API/symbol_ondemand/shared_library/TestSharedLibOnDemand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_source_line_breakpoint(self):
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)

thread = process.GetSelectedThread()
stack_frames = lldbutil.get_stack_frames(thread)
stack_frames = thread.frames
self.assertGreater(len(stack_frames), 2)

leaf_frame = stack_frames[0]
Expand Down Expand Up @@ -97,7 +97,7 @@ def test_symbolic_breakpoint(self):
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)

thread = process.GetSelectedThread()
stack_frames = lldbutil.get_stack_frames(thread)
stack_frames = thread.frames
self.assertGreater(len(stack_frames), 2)

leaf_frame = stack_frames[0]
Expand Down
Loading