Skip to content

[mlir] Improve doc in OpFormatGen.cpp (NFC) #117564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[mlir] Improve doc in OpFormatGen.cpp (NFC) #117564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72a8e79
[mlir] Improve doc in `OpFormatGen.cpp` (NFC)
chelini Nov 23, 2024
f7097b2
clang-format
chelini Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions mlir/tools/mlir-tblgen/OpFormatGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,8 +2033,9 @@ static void genPropDictPrinter(OperationFormat &fmt, Operator &op,
for (const NamedAttribute *namedAttr : fmt.usedAttributes)
body << " elidedProps.push_back(\"" << namedAttr->name << "\");\n";

// Add code to check attributes for equality with the default value
// for attributes with the elidePrintingDefaultValue bit set.
// Add code to check attributes for equality with their default values.
// Default-valued attributes will not be printed when their value matches the
// default.
for (const NamedAttribute &namedAttr : op.getAttributes()) {
const Attribute &attr = namedAttr.attr;
if (!attr.isDerivedAttr() && attr.hasDefaultValue()) {
Expand Down Expand Up @@ -2080,8 +2081,10 @@ static void genAttrDictPrinter(OperationFormat &fmt, Operator &op,
body << " elidedAttrs.push_back(\"" << key << "\");\n";
for (const NamedAttribute *attr : fmt.usedAttributes)
body << " elidedAttrs.push_back(\"" << attr->name << "\");\n";
// Add code to check attributes for equality with the default value
// for attributes with the elidePrintingDefaultValue bit set.

// Add code to check attributes for equality with their default values.
// Default-valued attributes will not be printed when their value matches the
// default.
for (const NamedAttribute &namedAttr : op.getAttributes()) {
const Attribute &attr = namedAttr.attr;
if (!attr.isDerivedAttr() && attr.hasDefaultValue()) {
Expand Down
Loading