Skip to content

[NFC]Update a ThinLTO test case #117584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024
Merged

[NFC]Update a ThinLTO test case #117584

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83c2755
[NFC]Update test case
mingmingl-llvm Nov 25, 2024
82cc4aa
Use -import-all-index to do backend compile and update distributed_i…
mingmingl-llvm Dec 2, 2024
89b994b
remove outdated comments
mingmingl-llvm Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llvm/test/ThinLTO/X86/distributed_indexes.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@
; RUN: llvm-dis %t1.bc.thinlto.bc -o - | FileCheck %s --check-prefix=DIS
; DIS: aliasee: null

; function-import pass crashed when alias is imported but aliasee doesn't.
Copy link
Contributor

@teresajohnson teresajohnson Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment and TODO can now be removed?

Copy link
Contributor Author

@mingmingl-llvm mingmingl-llvm Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Removed the outdated comments.

; TODO: Import both alias and aliasee, or neither of them.
; RUN: opt -passes=function-import -import-all-index -summary-file=%t1.bc.thinlto.bc %t1.bc -S -o - 2>&1 | FileCheck %s --check-prefix=IR

; Tests that analias definition is imported.
; IR: define available_externally void @analias

target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"

declare void @g(...)
Expand Down
Loading