Skip to content

[LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size #117604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
+6 −5
Merged

[LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size #117604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693f103
Set all the properties of ELFLinuxSigInfo to a non build dependent size
Jlalond Nov 25, 2024
7578b03
Add alignas(8) to handle padding of the struct with union
Jlalond Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lldb/source/Plugins/Process/elf-core/ThreadElfCore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ struct ELFLinuxSigInfo {
int32_t si_errno;
int32_t si_code;
// Copied from siginfo_t so we don't have to include signal.h on non 'Nix
// builds.
struct {
lldb::addr_t si_addr; /* faulting insn/memory ref. */
short int si_addr_lsb; /* Valid LSB of the reported address. */
// builds. Slight modifications to ensure no 32b vs 64b differences.
struct alignas(8) {
lldb::addr_t si_addr; /* faulting insn/memory ref. */
int16_t si_addr_lsb; /* Valid LSB of the reported address. */
union {
/* used when si_code=SEGV_BNDERR */
struct {
Expand All @@ -98,7 +98,8 @@ struct ELFLinuxSigInfo {
} bounds;
} sigfault;

enum { eUnspecified, eNT_SIGINFO } note_type;
enum SigInfoNoteType : uint8_t { eUnspecified, eNT_SIGINFO };
SigInfoNoteType note_type;

ELFLinuxSigInfo();

Expand Down
Loading