[compiler-rt][tests] Make this test case pass on AArch64 #117628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Do you have more details about why this is unsupported? Is it due to i128 atomics and constants? Could just TEST_16 be disabled? I tried to run it locally but I don't think this test ran. |
Contributor
Author
It doesn't surprise me, I'm using a very specific set of flags for compiler-rt, that makes it truly contain atomics (needed for Flang OpenMP experiments with atomics): Building it whith |
Collaborator
|
Does it fix the test to remove the const from this line:? Atomic loads from a constant address potentially needing to store/cas has always been an issue, but (hopefully) doesn't come up very often as it usually doesn't make a lot of sense. That would allow us to keep the test coverage from this test, which otherwise looks useful. |
Contributor
Author
The const removal is what we do in house to make CI all green. But after our discussion couple of weeks ago I somewhat remembered that it would be better to mark this test case unsupported on AArch64, hence this patch. |
Collaborator
|
Hmm. This doesn't seem to be a test for whether you can do an atomic load from constant memory, but just a test for atomic loads. I think we can remove the const and the test will make more sense. |
Initially, we wanted to make this test case unsupported on AArch64, but there is a value in its coverage, so it is better to make an amendment that could help it pass. Atomic loads from a constant address potentially needing to store/cas has always been an issue, but (hopefully) doesn't come up very often as it usually doesn't make a lot of sense. It doesn't seem to be a test for whether you can do an atomic load from constant memory, but just a test for atomic loads. Hence we can remove the `const` and the test will make more sense. See also D92832 and GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80878
pawosm-arm
force-pushed
the
disable-rt-atomic
branch
from
d045c30 to
fb29076
Compare
pawosm-arm
changed the title
Contributor
Author
Done. |
You can test this locally with the following command:git-clang-format --diff 535247841d8635bc998ec0ec4871ea22f27caba6 fb29076f77c4c695aa7af8dba88106af67ad71c3 --extensions c -- compiler-rt/test/builtins/Unit/atomic_test.cView the diff from clang-format here.diff --git a/compiler-rt/test/builtins/Unit/atomic_test.c b/compiler-rt/test/builtins/Unit/atomic_test.c
index 346c9b3be5..a00518a71f 100644
--- a/compiler-rt/test/builtins/Unit/atomic_test.c
+++ b/compiler-rt/test/builtins/Unit/atomic_test.c
@@ -145,10 +145,9 @@ typedef uint64_t maxuint_t;
#define LEN(array) (sizeof(array) / sizeof(array[0]))
__attribute__((aligned(16))) static char data[] = {
- 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17,
- 0x18, 0x19, 0x1a, 0x1b, 0x1c, 0x1d, 0x1e, 0x1f,
- 0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27,
- 0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d, 0x2e, 0x2f,
+ 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18, 0x19, 0x1a,
+ 0x1b, 0x1c, 0x1d, 0x1e, 0x1f, 0x20, 0x21, 0x22, 0x23, 0x24, 0x25,
+ 0x26, 0x27, 0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d, 0x2e, 0x2f,
};
uint8_t a8, b8;
|
Contributor
Author
The clang-format issue is none of our concern here. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/10415 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also D92832 and GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80878