Skip to content

[mlir][py] Enable disabling loading all registered #117643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[mlir][py] Enable disabling loading all registered #117643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions mlir/python/mlir/_mlir_libs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,16 @@ def _site_initialize():
logger = logging.getLogger(__name__)
post_init_hooks = []
disable_multithreading = False
# This flag disables eagerly loading all dialects. Eagerly loading is often
# not the desired behavior (see
# https://github.com/llvm/llvm-project/issues/56037), and the logic is that
# if any module has this attribute set, then we don't load all (e.g., it's
# being used in a solution where the loading is controlled).
disable_load_all_available_dialects = False

def process_initializer_module(module_name):
nonlocal disable_multithreading
nonlocal disable_load_all_available_dialects
try:
m = importlib.import_module(f".{module_name}", __name__)
except ModuleNotFoundError:
Expand All @@ -107,6 +114,8 @@ def process_initializer_module(module_name):
if bool(m.disable_multithreading):
logger.debug("Disabling multi-threading for context")
disable_multithreading = True
if hasattr(m, "disable_load_all_available_dialects"):
disable_load_all_available_dialects = True
return True

# If _mlirRegisterEverything is built, then include it as an initializer
Expand All @@ -130,10 +139,8 @@ def __init__(self, *args, **kwargs):
hook(self)
if not disable_multithreading:
self.enable_multithreading(True)
# TODO: There is some debate about whether we should eagerly load
# all dialects. It is being done here in order to preserve existing
# behavior. See: https://github.com/llvm/llvm-project/issues/56037
self.load_all_available_dialects()
if not disable_load_all_available_dialects:
self.load_all_available_dialects()
if init_module:
logger.debug(
"Registering translations from initializer %r", init_module
Expand Down
Loading