Skip to content

[mlir][unittest][nfc] Simplify getInversePermutation #117698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[mlir][unittest][nfc] Simplify getInversePermutation #117698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 12 additions & 22 deletions mlir/unittests/IR/AffineMapTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,17 +97,12 @@ TEST(AffineMapTest, getInversePermutation) {
auto resultsInv1 = inverseMap1.getResults();
EXPECT_EQ(resultsInv1.size(), 3UL);

// 1.1 Expect d2
AffineDimExpr expr = llvm::dyn_cast<AffineDimExpr>(resultsInv1[0]);
EXPECT_TRUE(expr && expr.getPosition() == 2);

// 1.2 Expect d0
expr = llvm::dyn_cast<AffineDimExpr>(resultsInv1[1]);
EXPECT_TRUE(expr && expr.getPosition() == 0);

// 1.3 Expect d3
expr = llvm::dyn_cast<AffineDimExpr>(resultsInv1[2]);
EXPECT_TRUE(expr && expr.getPosition() == 3);
// Expect (d2, d0, d3)
SmallVector<unsigned> expected = {2, 0, 3};
for (auto [idx, res] : llvm::enumerate(resultsInv1)) {
AffineDimExpr expr = llvm::dyn_cast<AffineDimExpr>(res);
EXPECT_TRUE(expr && expr.getPosition() == expected[idx]);
}
Copy link
Contributor

@javedabsar1 javedabsar1 Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.


// 2. (d0, d1, d2) -> (d1, d0 + d1, d0, d2, d1, d2, d1, d0)
auto sum = d0 + d1;
Expand All @@ -118,15 +113,10 @@ TEST(AffineMapTest, getInversePermutation) {
auto resultsInv2 = inverseMap2.getResults();
EXPECT_EQ(resultsInv2.size(), 3UL);

// 2.1 Expect d2
expr = llvm::dyn_cast<AffineDimExpr>(resultsInv2[0]);
EXPECT_TRUE(expr && expr.getPosition() == 2);

// 2.2 Expect d0
expr = llvm::dyn_cast<AffineDimExpr>(resultsInv2[1]);
EXPECT_TRUE(expr && expr.getPosition() == 0);

// 2.3 Expect d3
expr = llvm::dyn_cast<AffineDimExpr>(resultsInv2[2]);
EXPECT_TRUE(expr && expr.getPosition() == 3);
// Expect (d2, d0, d3)
expected = {2, 0, 3};
for (auto [idx, res] : llvm::enumerate(resultsInv2)) {
AffineDimExpr expr = llvm::dyn_cast<AffineDimExpr>(res);
EXPECT_TRUE(expr && expr.getPosition() == expected[idx]);
}
}
Loading