Skip to content

[GISel] Add generic implementation for @llvm.expect.with.probability when optimizations are disabled #117835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2024
Merged

[GISel] Add generic implementation for @llvm.expect.with.probability when optimizations are disabled #117835

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
747bc8a
[GISel] Add generic implementation for @llvm.expect.with.probability …
antangelo Nov 27, 2024
c8ac088
Merge branch 'main' of github.com:llvm/llvm-project into fix-llvm-exp…
antangelo Nov 27, 2024
dfcdc78
Replace generic test case with AArch64 MIR test
antangelo Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2431,6 +2431,7 @@ bool IRTranslator::translateKnownIntrinsic(const CallInst &CI, Intrinsic::ID ID,
case Intrinsic::invariant_end:
return true;
case Intrinsic::expect:
case Intrinsic::expect_with_probability:
case Intrinsic::annotation:
case Intrinsic::ptr_annotation:
case Intrinsic::launder_invariant_group:
Expand Down
1 change: 1 addition & 0 deletions llvm/test/CodeGen/Generic/builtin-expect-with-probability.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
; RUN: llc < %s
; RUN: llc -global-isel < %s

Copy link
Contributor

@arsenm arsenm Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing test is woefully inadequate. Should fix this in a pre-commit. This needs to have checks, and should not be a "Generic" test. Those cannot exist

Copy link
Contributor Author

@antangelo antangelo Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For generic changes like this, is it sufficient to test against one backend or does each one need its own coverage?

Copy link
Contributor Author

@antangelo antangelo Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved testing for GISel to the AArch64 IRTranslator no-op intrinsics suite, where similar tests lie, and removed the update to the generic one. I'll update the SelectionDAG tests to be specific and remove the generic one altogether separately.

declare i32 @llvm.expect.with.probability(i32, i32, double)

Expand Down