Skip to content

[TTI][X86] getShuffleCosts - for SK_PermuteTwoSrc, if the masks are known to be "inlane" no need to scale the costs by worst-case legalization #117999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2024
Merged

[TTI][X86] getShuffleCosts - for SK_PermuteTwoSrc, if the masks are known to be "inlane" no need to scale the costs by worst-case legalization #117999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba1f367
[TTI][X86] getShuffleCosts - for SK_PermuteTwoSrc, if the masks are k…
RKSimon Nov 28, 2024
23414e4
cleanup check prefixes
RKSimon Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86TargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,7 +1775,7 @@ InstructionCost X86TTIImpl::getShuffleCost(
}

// For 2-input shuffles, we must account for splitting the 2 inputs into many.
if (Kind == TTI::SK_PermuteTwoSrc && LT.first != 1) {
if (Kind == TTI::SK_PermuteTwoSrc && !IsInLaneShuffle && LT.first != 1) {
// We assume that source and destination have the same vector type.
InstructionCost NumOfDests = LT.first;
InstructionCost NumOfShufflesPerDest = LT.first * 2 - 1;
Expand Down
56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-insert_subvector-codesize.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-insert_subvector-latency.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-insert_subvector-sizelatency.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-insert_subvector.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-transpose-codesize.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-transpose-latency.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-transpose-sizelatency.ll
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions llvm/test/Analysis/CostModel/X86/shuffle-transpose.ll
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 7 additions & 13 deletions llvm/test/Transforms/PhaseOrdering/X86/pr94546.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,11 @@
; RUN: opt -mtriple=x86_64-- -mcpu=x86-64-v3 -passes="default<O3>" -S < %s | FileCheck %s --check-prefixes=AVX,AVX2

define <4 x double> @PR94546(<4 x double> %a, <4 x double> %b) {
; SSE2-LABEL: @PR94546(
; SSE2-NEXT: [[TMP1:%.*]] = shufflevector <4 x double> [[A:%.*]], <4 x double> [[B:%.*]], <2 x i32> <i32 0, i32 6>
; SSE2-NEXT: [[TMP2:%.*]] = shufflevector <4 x double> [[A]], <4 x double> [[B]], <2 x i32> <i32 1, i32 7>
; SSE2-NEXT: [[TMP3:%.*]] = fadd <2 x double> [[TMP1]], [[TMP2]]
; SSE2-NEXT: [[TMP4:%.*]] = shufflevector <2 x double> [[TMP3]], <2 x double> poison, <4 x i32> <i32 0, i32 poison, i32 poison, i32 1>
; SSE2-NEXT: ret <4 x double> [[TMP4]]
;
; SSE4-LABEL: @PR94546(
; SSE4-NEXT: [[TMP1:%.*]] = shufflevector <4 x double> [[A:%.*]], <4 x double> [[B:%.*]], <4 x i32> <i32 0, i32 poison, i32 poison, i32 6>
; SSE4-NEXT: [[TMP2:%.*]] = shufflevector <4 x double> [[A]], <4 x double> [[B]], <4 x i32> <i32 1, i32 poison, i32 poison, i32 7>
; SSE4-NEXT: [[TMP3:%.*]] = fadd <4 x double> [[TMP1]], [[TMP2]]
; SSE4-NEXT: ret <4 x double> [[TMP3]]
; SSE-LABEL: @PR94546(
; SSE-NEXT: [[TMP1:%.*]] = shufflevector <4 x double> [[A:%.*]], <4 x double> [[B:%.*]], <4 x i32> <i32 0, i32 poison, i32 poison, i32 6>
; SSE-NEXT: [[TMP2:%.*]] = shufflevector <4 x double> [[A]], <4 x double> [[B]], <4 x i32> <i32 1, i32 poison, i32 poison, i32 7>
; SSE-NEXT: [[TMP3:%.*]] = fadd <4 x double> [[TMP1]], [[TMP2]]
; SSE-NEXT: ret <4 x double> [[TMP3]]
;
; AVX-LABEL: @PR94546(
; AVX-NEXT: [[TMP1:%.*]] = shufflevector <4 x double> [[A:%.*]], <4 x double> [[B:%.*]], <4 x i32> <i32 0, i32 poison, i32 poison, i32 6>
Expand Down Expand Up @@ -50,4 +43,5 @@ define <4 x double> @PR94546(<4 x double> %a, <4 x double> %b) {
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
; AVX1: {{.*}}
; AVX2: {{.*}}
; SSE: {{.*}}
; SSE2: {{.*}}
; SSE4: {{.*}}