Add pass to turn function into Unreachable and script to find UB. #118034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pass to replace function bodies with 'unreachable' and a
script that checks if the result still verifies.
This can be used to find functions in llvm-lit tests that have
unconditional UB using
llvm-lit -j4 -sv -Dopt=~/find-ub-in-test.sh
Examples of found & fixed UB:
* b8d728a
* 684a82f
Differential Revision: https://reviews.llvm.org/D127607
Member
|
If the function contains UB, alive2 will give a warning like |
Contributor
Author
|
Yep the PR comes from a time when Alive2 didn't emit such a warning yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pass to replace function bodies with 'unreachable' and a script that checks if the result still verifies.
This can be used to find functions in llvm-lit tests that have unconditional UB using
Examples of found & fixed UB:
Differential Revision: https://reviews.llvm.org/D127607