Skip to content

[GlobalISel] Add G_ABDS and G_ABDU instructions #118122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 4, 2024
Merged

[GlobalISel] Add G_ABDS and G_ABDU instructions #118122

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f929ff
[GlobalISel] Add G_ABDS and G_ABDU instructions
tschuett Nov 29, 2024
fb0454a
fix typo
tschuett Nov 29, 2024
07cce36
global isel emiiter
tschuett Nov 30, 2024
9bb15cb
They are isCommutable=true.
tschuett Nov 30, 2024
c640bea
address review comments
tschuett Dec 3, 2024
ad8b237
restore etests
tschuett Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/test/MachineVerifier/test_abd_su.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ name: g_abd_su
body: |
bb.0:

%2:_(p0) = G_IMPLICIT_DEF
%3:_(p0) = G_IMPLICIT_DEF
%4:_(s1) = G_ABDS %2, %3
Copy link
Contributor

@arsenm arsenm Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the error check?

Copy link
Author

@tschuett tschuett Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the C++ error checking code under the assumption that the parameters are types and not ptypes and some other part of the system checks for misbehaviour.

Copy link
Contributor

@arsenm arsenm Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that does not remove the need to check that the correct error is produced. I also see the case with a pointer type in each operand is not rejected


%12:_(s64) = G_IMPLICIT_DEF
%13:_(s64) = G_IMPLICIT_DEF
%14:_(p0) = G_ABDS %12, %13

%23:_(<2 x s32>) = G_IMPLICIT_DEF
%24:_(<2 x s32>) = G_IMPLICIT_DEF
; CHECK: Generic vector abds/abdu must preserve number of lanes
Expand Down
Loading