Skip to content

[TableGen] Fix validateOperandClass for non Phyical Reg #118146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2024
Merged

[TableGen] Fix validateOperandClass for non Phyical Reg #118146

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cc10d4
Fix validateOperandClass for non Phyical Reg
jsji Nov 30, 2024
5b129ec
Use MCRegister
jsji Nov 30, 2024
5c362f5
Address comments
jsji Nov 30, 2024
be8cb1d
Update llvm/utils/TableGen/AsmMatcherEmitter.cpp
jsji Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/utils/TableGen/AsmMatcherEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,9 +2522,9 @@ static void emitValidateOperandClass(const CodeGenTarget &Target,
for (auto &MatchClassName : Table)
OS << " " << MatchClassName << ",\n";
OS << " };\n\n";
OS << " auto RegID=Operand.getReg().id();\n";
OS << " MatchClassKind OpKind = MCRegister::isPhysicalRegister(RegID)?"
"(MatchClassKind)Table[RegID]: InvalidMatchClass;\n";
OS << " unsigned RegID=Operand.getReg().id();\n";
OS << " MatchClassKind OpKind = MCRegister::isPhysicalRegister(RegID) ? "
"(MatchClassKind)Table[RegID] : InvalidMatchClass;\n";
OS << " return isSubclass(OpKind, Kind) ? "
<< "(unsigned)MCTargetAsmParser::Match_Success :\n "
<< " getDiagKindFromRegisterClass(Kind);\n }\n\n";
Expand Down