-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[llvm][CodeGen] Intrinsic llvm.powi.* code gen for vector arguments
#118242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7f5a128
[llvm][CodeGen] Intrinsic `llvm.powi.*` code gen for vector arguments
ylzsx 73281bc
Modify test file name. NFC
ylzsx e2c155d
Fixes for reviews.
ylzsx 685192d
Fixes for review.
ylzsx 2576758
code formatter
ylzsx 5abe500
Intrinsic `llvm.ldexp.*` should not be affected.
ylzsx 71a396e
Add comment.
ylzsx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 | ||
| ; RUN: llc --mtriple=loongarch64 --mattr=+lasx < %s | FileCheck %s | ||
|
|
||
| declare <8 x float> @llvm.ldexp.v8f32.i32(<8 x float>, i32) | ||
|
|
||
| define <8 x float> @ldexp_v8f32(<8 x float> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: ldexp_v8f32: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -80 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 72 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 64 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 0 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 0 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 0 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 1 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 1 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 2 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 2 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 3 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 3 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 4 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 4 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 5 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 5 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 6 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 6 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 7 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 7 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 64 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 72 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 80 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <8 x float> @llvm.ldexp.v8f32.i32(<8 x float> %va, i32 %b) | ||
| ret <8 x float> %res | ||
| } | ||
|
|
||
| declare <4 x double> @llvm.ldexp.v4f64.i32(<4 x double>, i32) | ||
|
|
||
| define <4 x double> @ldexp_v4f64(<4 x double> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: ldexp_v4f64: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -80 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 72 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 64 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 0 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 0 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 0 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 1 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 1 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 2 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 2 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 3 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 3 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 64 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 72 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 80 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <4 x double> @llvm.ldexp.v4f64.i32(<4 x double> %va, i32 %b) | ||
| ret <4 x double> %res | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 | ||
| ; RUN: llc --mtriple=loongarch64 --mattr=+lasx < %s | FileCheck %s | ||
|
|
||
| declare <8 x float> @llvm.powi.v8f32.i32(<8 x float>, i32) | ||
|
|
||
| define <8 x float> @powi_v8f32(<8 x float> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: powi_v8f32: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -80 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 72 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 64 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 0 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 0 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 0 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 1 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 1 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 2 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 2 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 3 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 3 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 4 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 4 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 5 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 5 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 6 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 6 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.w $a0, $xr0, 7 | ||
| ; CHECK-NEXT: movgr2fr.w $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powisf2) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.w $xr0, $a0, 7 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 64 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 72 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 80 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <8 x float> @llvm.powi.v8f32.i32(<8 x float> %va, i32 %b) | ||
| ret <8 x float> %res | ||
| } | ||
|
|
||
| declare <4 x double> @llvm.powi.v4f64.i32(<4 x double>, i32) | ||
|
|
||
| define <4 x double> @powi_v4f64(<4 x double> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: powi_v4f64: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -80 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 72 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 64 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 0 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 0 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powidf2) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 0 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 1 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powidf2) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 1 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 2 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powidf2) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 2 | ||
| ; CHECK-NEXT: xvst $xr0, $sp, 32 # 32-byte Folded Spill | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 0 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvpickve2gr.d $a0, $xr0, 3 | ||
| ; CHECK-NEXT: movgr2fr.d $fa0, $a0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(__powidf2) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: xvld $xr0, $sp, 32 # 32-byte Folded Reload | ||
| ; CHECK-NEXT: xvinsgr2vr.d $xr0, $a0, 3 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 64 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 72 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 80 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <4 x double> @llvm.powi.v4f64.i32(<4 x double> %va, i32 %b) | ||
| ret <4 x double> %res | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 | ||
| ; RUN: llc --mtriple=loongarch64 --mattr=+lsx < %s | FileCheck %s | ||
|
|
||
| declare <4 x float> @llvm.ldexp.v4f32.i32(<4 x float>, i32) | ||
|
|
||
| define <4 x float> @ldexp_v4f32(<4 x float> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: ldexp_v4f32: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -48 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 40 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 32 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: vst $vr0, $sp, 0 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: vreplvei.w $vr0, $vr0, 0 | ||
| ; CHECK-NEXT: # kill: def $f0 killed $f0 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: vinsgr2vr.w $vr0, $a0, 0 | ||
| ; CHECK-NEXT: vst $vr0, $sp, 16 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: vld $vr0, $sp, 0 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vreplvei.w $vr0, $vr0, 1 | ||
| ; CHECK-NEXT: # kill: def $f0 killed $f0 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: vld $vr0, $sp, 16 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vinsgr2vr.w $vr0, $a0, 1 | ||
| ; CHECK-NEXT: vst $vr0, $sp, 16 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: vld $vr0, $sp, 0 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vreplvei.w $vr0, $vr0, 2 | ||
| ; CHECK-NEXT: # kill: def $f0 killed $f0 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: vld $vr0, $sp, 16 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vinsgr2vr.w $vr0, $a0, 2 | ||
| ; CHECK-NEXT: vst $vr0, $sp, 16 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: vld $vr0, $sp, 0 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vreplvei.w $vr0, $vr0, 3 | ||
| ; CHECK-NEXT: # kill: def $f0 killed $f0 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexpf) | ||
| ; CHECK-NEXT: movfr2gr.s $a0, $fa0 | ||
| ; CHECK-NEXT: vld $vr0, $sp, 16 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vinsgr2vr.w $vr0, $a0, 3 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 32 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 40 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 48 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <4 x float> @llvm.ldexp.v4f32.i32(<4 x float> %va, i32 %b) | ||
| ret <4 x float> %res | ||
| } | ||
|
|
||
| declare <2 x double> @llvm.ldexp.v2f64.i32(<2 x double>, i32) | ||
|
|
||
| define <2 x double> @ldexp_v2f64(<2 x double> %va, i32 %b) nounwind { | ||
| ; CHECK-LABEL: ldexp_v2f64: | ||
| ; CHECK: # %bb.0: # %entry | ||
| ; CHECK-NEXT: addi.d $sp, $sp, -48 | ||
| ; CHECK-NEXT: st.d $ra, $sp, 40 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: st.d $fp, $sp, 32 # 8-byte Folded Spill | ||
| ; CHECK-NEXT: vst $vr0, $sp, 0 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: addi.w $fp, $a0, 0 | ||
| ; CHECK-NEXT: vreplvei.d $vr0, $vr0, 0 | ||
| ; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: vinsgr2vr.d $vr0, $a0, 0 | ||
| ; CHECK-NEXT: vst $vr0, $sp, 16 # 16-byte Folded Spill | ||
| ; CHECK-NEXT: vld $vr0, $sp, 0 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vreplvei.d $vr0, $vr0, 1 | ||
| ; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 killed $vr0 | ||
| ; CHECK-NEXT: move $a0, $fp | ||
| ; CHECK-NEXT: bl %plt(ldexp) | ||
| ; CHECK-NEXT: movfr2gr.d $a0, $fa0 | ||
| ; CHECK-NEXT: vld $vr0, $sp, 16 # 16-byte Folded Reload | ||
| ; CHECK-NEXT: vinsgr2vr.d $vr0, $a0, 1 | ||
| ; CHECK-NEXT: ld.d $fp, $sp, 32 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: ld.d $ra, $sp, 40 # 8-byte Folded Reload | ||
| ; CHECK-NEXT: addi.d $sp, $sp, 48 | ||
| ; CHECK-NEXT: ret | ||
| entry: | ||
| %res = call <2 x double> @llvm.ldexp.v2f64.i32(<2 x double> %va, i32 %b) | ||
| ret <2 x double> %res | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole function is actually the wrong place to split the vector (see how there are no other UnrollVectorOps uses in DAGTypeLegalizer). The description also says your problem is when the libcall is used, so you'd want to change the other path? Does the libcall emission below need to directly handle the vector case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not entirely sure I understand what you mean. Could you please clarify?
Are you referring to the approach used in my first commit 7f5a128 ? If so, in that commit, you mentioned not to check for the
SIGN_EXTEND_INREGnode, but this node is generated in thisifstatement here.(SExtPromotedIntegerwill generate aSIGN_EXTEND_INREGnode).Other info:
PromoteIntOp_ExpOpand generate aSIGN_EXTEND_INREGnode, soExponentHasSizeOfInt=false(32 != 64) and report an error.Additionally, AArch64 and X86 will get
ExponentHasSizeOfInt=true, because in these backends, i32 is valid and was not promoted toSIGN_EXTEND_INREG(i64) previously. So, they generate right code sequences.fpowiandfldexpwill call thePromoteIntOp_ExpOpfunction.(Flow:llvm::DAGTypeLegalizer::PromoteIntegerOperand->llvm::DAGTypeLegalizer::PromoteIntOp_ExpOp)If not, could you provide more specific modification suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@topperc what are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are calls to
UnrollVectorOpsin several places in LegalizeVectorTypes.cppThis comment where the libcall below is created seems relevant
My suggestion to unroll here was so that we wouldn't promote past sizeof(int). If we wait until LegalizeDAG.cpp to unroll the operation, the damage to the integer type has already been done. For RISC-V its harmless because
signed intis supposed to be passed sign extended to 64-bits according to the ABI.Hypothetically, if powi took an
unsigned intas an argument, then type legalization would use zero extend, but the RISC-V ABI wantsunsigned intto be passed sign extended. So LegalizeDAG would need to insert a SIGN_EXTEND_INREG to fix. I guess it would need to use the getIntSize() and shouldSignExtendTypeInLibCall to know what it needs to do in that case.If we don't unroll here I guess the best fix in LegalizeDAG would also be to use
getIntSize()andshouldSignExtendTypeInLibCalland use computeNumSignBits to know if a SIGN_EXTEND_INREG needs to be inserted?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to me to handle this when emitting the call, where ABI constraints would naturally be handled. This can be sign extended here, and the call emission can truncate or sext_inreg as required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The POWI code in LegalizeDAG calls
SelectionDAGLegalize::ExpandFPLibCallwhich will callTargetLowering::makeLibCallusing the promoted type.makeLibCallcallsgetTypeForEVTwhich will returni64due to the promotion. That's what will be used by calling lowering, but that's the wrong type for it to do the right thing. We need to get an i32 Type* into call lowering, but we no longer have it. We'll need to call getIntSize() to get the size and pass it along somehow. That requires refactoring several interfaces or adding new ones. Not sure if call lowering would also expect the SDValue for the argument to have i32 type.My unrolling proposal avoided that by scalarizing it and letting the newly created scalar powi calls get converted to libcalls while we're still in type legalization. That's how we currently handle the scalar powi case. Are you also suggesting we should move the scalar handling to LegalizeDAG as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeLibCall should really be looking at the signature of the underlying call, but RuntimeLibcalls currently does not record this information. TargetLibraryInfo does, which is separate for some reason. This keeps coming up as a problem, these really need to be merged in some way (cc @jhuber6).
Taking the type from the DAG node isn't strictly correct, it's just where we've ended up. This came up recently for the special case in ExpandFPLibCall to sign extend the integer argument for FLDEXP.
Practically speaking, I don't think any targets will have a vector powi implementation (I at least don't see any in RuntimeLibcalls), so unrolling works out. I guess this could get a fixme and go ahead for now, but it's still a hack