Skip to content

FunctionDecl::getFunctionTypeLoc: ignore function type attributes #118420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2025
Merged

FunctionDecl::getFunctionTypeLoc: ignore function type attributes #118420

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b6f0130
FunctionDecl::getFunctionTypeLoc: ignore function type attributes
Dec 3, 2024
d5faa43
tmp: Add test and replace ignore parens by getAsAdjusted
Dec 8, 2024
7e647b9
tmp: getAsAdjusted use getModifiedLoc, replace the loop by a custom one
Dec 8, 2024
21af94d
tmp: fix test
Dec 8, 2024
f125b5e
tmp: fix typos, add tests
Dec 11, 2024
6d749da
Fix clangd test
Dec 11, 2024
3d18b08
Support MacroQualifiedTypeLoc, fix typos
Dec 13, 2024
94079e1
fmt
Dec 13, 2024
1470d04
Merge branch 'main' into clang-func-decl-get-func-type-loc-when-func-…
resistor Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions clang/lib/AST/Decl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3876,8 +3876,17 @@ bool FunctionDecl::doesDeclarationForceExternallyVisibleDefinition() const {

FunctionTypeLoc FunctionDecl::getFunctionTypeLoc() const {
const TypeSourceInfo *TSI = getTypeSourceInfo();
return TSI ? TSI->getTypeLoc().IgnoreParens().getAs<FunctionTypeLoc>()
: FunctionTypeLoc();

if (!TSI)
return FunctionTypeLoc();

TypeLoc TL = TSI->getTypeLoc().IgnoreParens();

// ignore function type attributes
Copy link
Collaborator

@AaronBallman AaronBallman Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other sugars we need to ignore? e.g., a ParenType via:

void (foo)(int f) {}

Copy link
Contributor Author

@v01dXYZ v01dXYZ Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. But to implement it in its updated form, I mimicked getAsAdjusted. So currently, it supports ParenType and AttributedType. I think I should add MacroQualifiedType for example.

while (auto ATL = TL.getAs<AttributedTypeLoc>())
TL = ATL.getModifiedLoc();
Copy link
Collaborator

@erichkeane erichkeane Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't THINK we want this? We want to keep around the 'type' as modified by the attributed type (so if it is no_return, we want to make sure we have a noreturn function type for example). So I would think we would want the Equivalent type here?

Copy link
Contributor Author

@v01dXYZ v01dXYZ Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad I've made this error. I'll start by adding your example as a test.


return TL.getAs<FunctionTypeLoc>();
}

SourceRange FunctionDecl::getReturnTypeSourceRange() const {
Expand Down
Loading