[mlir][NFC] Fix format of comments for foldHook
#118453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-mlir-core Author: Longsheng Mou (CoTinker) ChangesFull diff: https://github.com/llvm/llvm-project/pull/118453.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/OperationSupport.h b/mlir/include/mlir/IR/OperationSupport.h
index 1b93f3d3d04fe8..89a2fa985a9693 100644
--- a/mlir/include/mlir/IR/OperationSupport.h
+++ b/mlir/include/mlir/IR/OperationSupport.h
@@ -248,13 +248,11 @@ class OperationName {
///
/// 1. They can leave the operation alone and without changing the IR, and
/// return failure.
- /// 2. They can mutate the operation in place, without changing anything
- /// else
- /// in the IR. In this case, return success.
+ /// 2. They can mutate the operation in-place, without changing anything
+ /// else in the IR. In this case, return success.
/// 3. They can return a list of existing values that can be used instead
- /// of
- /// the operation. In this case, fill in the results list and return
- /// success. The caller will remove the operation and use those results
+ /// of the operation. In this case, fill in the results list and return
+ /// success. The caller will remove the operation and use those results
/// instead.
///
/// This allows expression of some simple in-place canonicalizations (e.g.
|
Member
|
@llvm/pr-subscribers-mlir Author: Longsheng Mou (CoTinker) ChangesFull diff: https://github.com/llvm/llvm-project/pull/118453.diff 1 Files Affected:
diff --git a/mlir/include/mlir/IR/OperationSupport.h b/mlir/include/mlir/IR/OperationSupport.h
index 1b93f3d3d04fe8..89a2fa985a9693 100644
--- a/mlir/include/mlir/IR/OperationSupport.h
+++ b/mlir/include/mlir/IR/OperationSupport.h
@@ -248,13 +248,11 @@ class OperationName {
///
/// 1. They can leave the operation alone and without changing the IR, and
/// return failure.
- /// 2. They can mutate the operation in place, without changing anything
- /// else
- /// in the IR. In this case, return success.
+ /// 2. They can mutate the operation in-place, without changing anything
+ /// else in the IR. In this case, return success.
/// 3. They can return a list of existing values that can be used instead
- /// of
- /// the operation. In this case, fill in the results list and return
- /// success. The caller will remove the operation and use those results
+ /// of the operation. In this case, fill in the results list and return
+ /// success. The caller will remove the operation and use those results
/// instead.
///
/// This allows expression of some simple in-place canonicalizations (e.g.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.